Fix params initialization at GitHelper::commit()

phansys · phansys · commit 1c43ecce5bc2 · 2018-05-23T10:09:08.000-03:00
diff --git a/src/Helper/GitHelper.php b/src/Helper/GitHelper.php
@@ -667,7 +667,7 @@ public function syncWithRemote($remote, $branchName = null)
 
     public function commit($message, array $options = [])
     {
-        $params = '';
+        $params = [];
 
         foreach ($options as $option => $value) {
             if (is_int($option)) {
@@ -681,7 +681,7 @@ public function commit($message, array $options = [])
         $tmpName = $this->filesystemHelper->newTempFilename();
         file_put_contents($tmpName, $message);
 
-        $this->processHelper->runCommand(array_merge(['git', 'commit', '-F', $tmpName], $params));
+        $this->processHelper->runCommand(array_merge(['git', 'commit', '--file', $tmpName], $params));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -667,7 +667,7 @@ public function syncWithRemote($remote, $branchName = null)`
`667`	`667`
`668`	`668`	`public function commit($message, array $options = [])`
`669`	`669`	`{`
`670`		`- $params = '';`
	`670`	`+ $params = [];`
`671`	`671`
`672`	`672`	`foreach ($options as $option => $value) {`
`673`	`673`	`if (is_int($option)) {`
`@@ -681,7 +681,7 @@ public function commit($message, array $options = [])`
`681`	`681`	`$tmpName = $this->filesystemHelper->newTempFilename();`
`682`	`682`	`file_put_contents($tmpName, $message);`
`683`	`683`
`684`		`- $this->processHelper->runCommand(array_merge(['git', 'commit', '-F', $tmpName], $params));`
	`684`	`+ $this->processHelper->runCommand(array_merge(['git', 'commit', '--file', $tmpName], $params));`
`685`	`685`	`}`
`686`	`686`
`687`	`687`	`/**`