Skip to content
This repository was archived by the owner on Aug 5, 2019. It is now read-only.

DateBoxAppended setStartDate_(Date) and setEndDate(Date) isn't working #424

Open
andrezimmermann opened this issue Aug 29, 2013 · 1 comment

Comments

@andrezimmermann
Copy link

I'm having troubles with the DateBoxAppended, to set the start or end date. Can you confirm to me that on master branch is it working without calling the DateBoxBase.reconfigure()? To fix it I exposed the reconfigure() at the DateBoxAppended and rewrote the DateBoxAppendedAdapter.configure() method. Seems to have fixed my issue. Since I'm new to github how I can proceed to submit my patch?

@caarlos0
Copy link
Contributor

Hi.

Been awhile since I last used GWT... so I can't confirm this to you.

About submit, you can create a fork of this repo to your user. Then, I recommend you to create a feature branch, something like:

git checkoub -b databox-fix
# do your work...
git add file1 file2
git commit -m 'fixes bug in dateboxappender - closes #424'
git push

Then, when you can create a pull-request from your feature branch to our master.

Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants