Skip to content
This repository was archived by the owner on Nov 23, 2018. It is now read-only.
This repository was archived by the owner on Nov 23, 2018. It is now read-only.

JS filename replacement in HTML is not parsing script tag when HTML is actually a server side template #154

Open
@kierans

Description

@kierans

Similar to issue #153, for my project the JS is concatenated/minified by h5bp however the HTML pages are actually JSP tag templates. The current replacement regexp however is not parsing the script block when JSP snippets are in the code eg:

<!-- scripts concatenated and minified via build script -->
<script src="<%= application.getContextPath() + "/js/main.js" %>"></script>
<!-- end scripts -->

doesn't get parsed and main.js is not replaced with the correct file name.

I'll be submitting a pull request with a fix where quotes are included in capture groups and non greedy qualifiers used to achieve better matching.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions