Skip to content

Conversation

@myronchen-git
Copy link
Member

@myronchen-git myronchen-git commented Nov 8, 2025

Fixes #7990

What changes did you make?

  • Added a new iframe property, allow, in the Food Oasis project markdown.

  • Updated the project layout to include an allow attribute for iframes.

    Note that this will leave an allow attribute that is set to an empty String in the HTML if there is no allow property in a project markdown file.

Why did you make the changes (we will use this info to test)?

  • The Food Oasis widget was not allowing users to re-center on their current location.
  • The project layout had to be changed, because the rendering was not reading the new allow property from the markdown files in the _projects directory.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Before Changes

Visuals after changes are applied

After Changes

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b myronchen-git-allow-food-oasis-widget-geolocation-7990 gh-pages
git pull https://github.com/myronchen-git/website.git allow-food-oasis-widget-geolocation-7990

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 8, 2025
@myronchen-git myronchen-git added this to the 03.02 Onboarding flow milestone Nov 8, 2025
@myronchen-git
Copy link
Member Author

I do not know if there is a procedure for changing the code for the project layout (_layouts\project.html). Please inform me if I am missing something.

@lastCoyotes lastCoyotes self-assigned this Nov 10, 2025
@lastCoyotes
Copy link
Member

ETA: By 6pm today.
Availability: Mon-Thurs 12p-6p

Copy link
Member

@lastCoyotes lastCoyotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changed requesting in the scope of the issue works and the visual and functional changes are consistent.

I looked into your question as well and followed through your process you left in #7990 and I believe the changes you made to the project.html file were necessary. I couldn't find anything that would interfere with other iframes on other pages. I don't see any glaring issues to making this change outside of the issue, so I approve this PR!

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myronchen-git great job with this issue, I tested your changes locally and the locator button now works correctly. Your changes to project.html were necessary and do not affect other projects as only the Food Oasis page contains an iframe.

Everything with the PR looks good as well, thanks for the thorough explanation of the steps you took and why.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 12, 2025
@daras-cu daras-cu merged commit f038e38 into hackforla:gh-pages Nov 12, 2025
12 checks passed
@myronchen-git myronchen-git deleted the allow-food-oasis-widget-geolocation-7990 branch November 20, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Update the iframe Link for Integration of the Food Oasis Widget

3 participants