-
-
Notifications
You must be signed in to change notification settings - Fork 846
Allow geolocation for Food Oasis widget #8413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow geolocation for Food Oasis widget #8413
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
I do not know if there is a procedure for changing the code for the project layout ( |
|
ETA: By 6pm today. |
lastCoyotes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changed requesting in the scope of the issue works and the visual and functional changes are consistent.
I looked into your question as well and followed through your process you left in #7990 and I believe the changes you made to the project.html file were necessary. I couldn't find anything that would interfere with other iframes on other pages. I don't see any glaring issues to making this change outside of the issue, so I approve this PR!
daras-cu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myronchen-git great job with this issue, I tested your changes locally and the locator button now works correctly. Your changes to project.html were necessary and do not affect other projects as only the Food Oasis page contains an iframe.
Everything with the PR looks good as well, thanks for the thorough explanation of the steps you took and why.
Fixes #7990
What changes did you make?
Added a new
iframeproperty,allow, in the Food Oasis project markdown.Updated the
projectlayout to include anallowattribute foriframes.Note that this will leave an
allowattribute that is set to an empty String in the HTML if there is noallowproperty in a project markdown file.Why did you make the changes (we will use this info to test)?
projectlayout had to be changed, because the rendering was not reading the newallowproperty from the markdown files in the_projectsdirectory.CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied