Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to documents should have a color showing who made the edit #588

Open
dessalines opened this issue Oct 13, 2017 · 5 comments
Open

Edits to documents should have a color showing who made the edit #588

dessalines opened this issue Oct 13, 2017 · 5 comments
Labels
enhancement Wants to improvide an existing feature Hacktoberfest

Comments

@dessalines
Copy link

When collaborating on a document, its impossible to see who made the addition / edit. Other systems like piratepad do this by showing a color next to the editor, and providing a way for those without a sign in to name themselves.

@SISheogorath SISheogorath added enhancement Wants to improvide an existing feature Hacktoberfest labels Oct 13, 2017
@SISheogorath
Copy link
Contributor

Sounds like a duplicate of #268 and #503
Can you confirm this?

@dessalines
Copy link
Author

Yes it looks like they are, but I've never seen the color-coding when testing out anonymous editors.

@SISheogorath
Copy link
Contributor

SISheogorath commented Oct 14, 2017

in case of anonymous coding there is no color-coding. Since we don't store the authorship in the database for guests

@dessalines
Copy link
Author

hrm.... that seems like a bad idea, especially if you want to do consistent naming. Just make them an unverified user and set a cookie on their browser.

@SISheogorath
Copy link
Contributor

There is a space for improvements. No doubt.

That's why ideas and pull requests to tackle these issues are welcome 👍

I would say that #268 is a good point to start, since it's not too difficult to implement and it's a good way to understand how guests are currently handled in HackMD.

Providing detailed information who edited what and when needs way more work in backend and is nothing we will be able to implement over night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Wants to improvide an existing feature Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants