Skip to content
This repository was archived by the owner on Jul 23, 2020. It is now read-only.

Commit 9615cea

Browse files
bdutrohadess
authored andcommitted
iio: Fix possible incorrect mask calculation
On some machines, iio-sensor-proxy was returning all 0's for IIO sensor values. It turns out that the bits_used for this sensor is 32, which makes the mask calculation: *mask = (1 << 32) - 1; If the compiler interprets the 1 literals as 32-bit ints, it generates undefined behavior depending on compiler version and optimization level. On my system, it optimizes out the shift, so the mask value becomes *mask = (1) - 1; With a mask value of 0, iio-sensor-proxy will always return 0 for every axis. Avoid incorrect 0 values caused by compiler optimization. Closes: #270
1 parent b320a32 commit 9615cea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/iio-buffer-utils.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,9 @@ iioutils_get_type (unsigned *is_signed,
136136
*be = (endianchar == 'b');
137137
*bytes = padint / 8;
138138
if (*bits_used == 64)
139-
*mask = ~0;
139+
*mask = ~G_GUINT64_CONSTANT(0);
140140
else
141-
*mask = (1 << *bits_used) - 1;
141+
*mask = (G_GUINT64_CONSTANT(1) << *bits_used) - G_GUINT64_CONSTANT(1);
142142
*is_signed = (signchar == 's');
143143

144144
g_debug ("Got type for %s: is signed: %d, bytes: %d, bits_used: %d, shift: %d, mask: 0x%" G_GUINT64_FORMAT ", be: %d",

0 commit comments

Comments
 (0)