Histogram as plot type for clusterplot

[marabuuu]

Hi @haesleinhuepf,

This PR closes Issue #56.

I have created a class Plotter as a base class and then class ScatterPlotter and class HistogramPlotter as the subclasses. Therefore, I renamed _scatterplot.py into _plot.py and also renamed the corresponding function from scatterplot into plot.

If you want any modifications, just let me know and I try to include them 🌻

Best,
Mara

[marabuuu]

@haesleinhuepf 🌻

[haesleinhuepf]

Hi @marabuuu ,

thanks for working on this!

I'm afraid your modifications are a bit too invasive for my taste. Most importantly: renaming a function such as scatterplot to plot will break all notebooks out in the wild which used the scatterplot function. Hence, the minimum we need to do is to have a scatterplot function that calls plot under the hood. I would also be ok if the function remains "scatterplot". The fact that it displays a histogram is a special case anyway.

Also, I executed the exampe scatterplot notebook in both the old and the new version. The dual-view plot at the very end looked like this in the old version:

It looks like this in the new version:

I see some issues:

1. The error in the top left corner.
2. There is a new tool bar introduced.
3. The plot can be resized in the bottom right.
4. Most importantly, we cannot select an intensity range in the histogram. It's not interactive like the 2D plot.

Did you build 2. and 3. intentionally? Do these come with side-effects, does this collide with other functionality?

Would you mind taking another look? Consider making the changes absolutely minimal to not break workflows of people who used these tools before.

Thanks!

Best,
Robert

[marabuuu]

Oki thank you for your help @haesleinhuepf ! I will take a look ⭐️

[marabuuu]

Hi @haesleinhuepf,

I have tried to incorporate all requested changes now. Let me know if something else should be modified. Thank you again for your help!

Best,
Mara

[marabuuu]

I realised that there is an Issue with this PR, so I will close it for now and reopen it once I fixed it :)