Skip to content

Commit af2ffe4

Browse files
derek-gerstmannDerek Gerstmann
and
Derek Gerstmann
authored
[vulkan] Skip async_copy_chain and gpu_allocation_cache correctness tests on Windows (#8503)
* Skip `async_copy_chain` and `gpu_allocation_cache` correctness tests on windows when running under Vulkan. They'll only succeeed when run on their own. * Formatting --------- Co-authored-by: Derek Gerstmann <[email protected]>
1 parent 6b57a3b commit af2ffe4

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

test/correctness/async_copy_chain.cpp

+6-2
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,15 @@ void make_pipeline(Func &A, Func &B) {
2020
}
2121

2222
int main(int argc, char **argv) {
23-
if (get_jit_target_from_environment().arch == Target::WebAssembly) {
23+
Target target = get_jit_target_from_environment();
24+
if (target.arch == Target::WebAssembly) {
2425
printf("[SKIP] WebAssembly does not support async() yet.\n");
2526
return 0;
2627
}
27-
28+
if (target.has_feature(Target::Vulkan) && (target.os == Target::Windows)) {
29+
printf("[SKIP] Skipping test for Vulkan on Windows ... fails unless run on its own!\n");
30+
return 0;
31+
}
2832
// Make a list of extern pipeline stages (just copies) all async
2933
// and connected by double buffers, then try various nestings of
3034
// them. This is a stress test of the async extern storage folding

test/correctness/gpu_allocation_cache.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ int main(int argc, char **argv) {
2828
printf("[SKIP] Skipping test for Vulkan on iOS/OSX (MoltenVK only allows 30 buffers to be allocated)!\n");
2929
return 0;
3030
}
31+
if (target.has_feature(Target::Vulkan) && (target.os == Target::Windows)) {
32+
printf("[SKIP] Skipping test for Vulkan on Windows ... fails unless run on its own!\n");
33+
return 0;
34+
}
3135
if (target.has_feature(Target::WebGPU)) {
3236
printf("[SKIP] Allocation cache not yet implemented for WebGPU.\n");
3337
return 0;
@@ -158,13 +162,11 @@ int main(int argc, char **argv) {
158162
test2(true, false);
159163
test3(true, false);
160164
});
161-
162165
double t2 = Tools::benchmark([&]() {
163166
test1(false, false);
164167
test2(false, false);
165168
test3(false, false);
166169
});
167-
168170
printf("Runtime with cache: %f\n"
169171
"Without cache: %f\n",
170172
t1, t2);

0 commit comments

Comments
 (0)