Skip to content

Commit beedd49

Browse files
committedMar 18, 2025·
Merge branch 'main' into dg-vulkan-rpi
2 parents fbb5c4e + 813920f commit beedd49

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+549
-244
lines changed
 

‎CMakeLists.txt

+5-4
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,12 @@ function(set_halide_compiler_warnings NAME)
126126

127127
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wcast-qual>
128128
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wignored-qualifiers>
129-
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Woverloaded-virtual>
130129
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wimplicit-fallthrough>
131130

132-
$<$<CXX_COMPILER_ID:GNU>:-Wsuggest-override>
131+
# GCC warns when these warnings are given to plain-C sources
132+
$<$<COMPILE_LANG_AND_ID:CXX,GNU,Clang,AppleClang>:-Woverloaded-virtual>
133+
$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-Wsuggest-override>
134+
$<$<COMPILE_LANG_AND_ID:CXX,GNU,Clang,AppleClang>:-Wno-old-style-cast>
133135

134136
$<$<CXX_COMPILER_ID:Clang,AppleClang>:-Winconsistent-missing-destructor-override>
135137
$<$<CXX_COMPILER_ID:Clang,AppleClang>:-Winconsistent-missing-override>
@@ -139,7 +141,6 @@ function(set_halide_compiler_warnings NAME)
139141
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-float-conversion>
140142
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-float-equal>
141143
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-missing-field-initializers>
142-
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-old-style-cast>
143144
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-shadow>
144145
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-sign-conversion>
145146
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-switch-enum>
@@ -195,7 +196,7 @@ option(THREADS_PREFER_PTHREAD_FLAG "When enabled, prefer to use the -pthread fla
195196
find_package(Threads REQUIRED)
196197

197198
## LLVM
198-
find_package(Halide_LLVM 18...20 REQUIRED
199+
find_package(Halide_LLVM 18...99 REQUIRED # Use 99 to fake a minimum-only constraint
199200
COMPONENTS WebAssembly X86
200201
OPTIONAL_COMPONENTS AArch64 ARM Hexagon NVPTX PowerPC RISCV)
201202

‎cmake/HalidePackageConfigHelpers.cmake

+2-1
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,10 @@ function(_Halide_install_pkgdeps)
7878
)
7979

8080
set(depFile "${CMAKE_CURRENT_BINARY_DIR}/${ARG_FILE_NAME}")
81+
set(installPrefix "$<$<PATH:IS_RELATIVE,${ARG_DESTINATION}>:\${CMAKE_INSTALL_PREFIX}/>")
8182

8283
_Halide_install_code(
83-
"file(READ \"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${ARG_DESTINATION}/${ARG_EXPORT_FILE}\" target_cmake)"
84+
"file(READ \"\$ENV{DESTDIR}${installPrefix}${ARG_DESTINATION}/${ARG_EXPORT_FILE}\" target_cmake)"
8485
"file(WRITE \"${depFile}.in\" \"\")"
8586
)
8687

0 commit comments

Comments
 (0)
Please sign in to comment.