Add [[noreturn]] to CompileTimeErrorReporter::error

Author: alexreinking

python_bindings/src/halide/halide_/PyError.cpp

@@ -16,13 +16,10 @@ class HalidePythonCompileTimeErrorReporter : public CompileTimeErrorReporter {
         halide_python_print(nullptr, msg);
     }
 
-    void error(const char *msg) override {
+    [[noreturn]] void error(const char *msg) override {
         // This method is called *only* from the Compiler -- never from jitted
         // code -- so throwing an Error here is the right thing to do.
-
         throw Error(msg);
-
-        // This method must not return!
     }
 };
 

python_bindings/stub/PyStubImpl.cpp

@@ -37,9 +37,8 @@ class HalidePythonCompileTimeErrorReporter : public CompileTimeErrorReporter {
         py::print(msg, py::arg("end") = "");
     }
 
-    void error(const char *msg) override {
+    [[noreturn]] void error(const char *msg) override {
         throw Halide::Error(msg);
-        // This method must not return!
     }
 };
 

src/Error.h

@@ -83,7 +83,7 @@ class CompileTimeErrorReporter {
 public:
     virtual ~CompileTimeErrorReporter() = default;
     virtual void warning(const char *msg) = 0;
-    virtual void error(const char *msg) = 0;
+    [[noreturn]] virtual void error(const char *msg) = 0;
 };
 
 /** The default error reporter logs to stderr, then throws an exception

test/correctness/custom_error_reporter.cpp

@@ -33,7 +33,7 @@ class MyCustomErrorReporter : public Halide::CompileTimeErrorReporter {
         warnings_occurred++;
     }
 
-    void error(const char *msg) override {
+    [[noreturn]] void error(const char *msg) override {
         // Emitting "error.*:" to stdout or stderr will cause CMake to report the
         // test as a failure on Windows, regardless of error code returned.
         // The error text we get from ErrorReport probably contains some variant