Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build bots are swamped with old PRs #8576

Open
mcourteaux opened this issue Feb 13, 2025 · 3 comments
Open

Build bots are swamped with old PRs #8576

mcourteaux opened this issue Feb 13, 2025 · 3 comments
Labels
dev_meeting Topic to be discussed at the next dev meeting discussion For talking about potential improvements & changes. gha-buildbots

Comments

@mcourteaux
Copy link
Contributor

We should take out halidebuildbots as reviewer from old PRs. Everytime we commit to main, the bots are working for close to a day to process all PRs. All active PRs are needlessly stalled because we are "waiting for green" while the bots are compiling code from 2019.

@mcourteaux mcourteaux added discussion For talking about potential improvements & changes. gha-buildbots labels Feb 13, 2025
@abadams
Copy link
Member

abadams commented Feb 13, 2025

The buildbots are rechecking PRs that haven't had a commit pushed to them? Can you point me to an instance? That shouldn't be happening.

@mcourteaux
Copy link
Contributor Author

mcourteaux commented Feb 14, 2025

Here is one still going right now: https://buildbot.halide-lang.org/master/#/builders/67/builds/30, from #8207.

It seems that buildbots don't retry when there are merge conflicts in the files.

@mcourteaux mcourteaux added the dev_meeting Topic to be discussed at the next dev meeting label Feb 14, 2025
@mcourteaux
Copy link
Contributor Author

To be honest, I think this is desirable behavior from the bots. You wouldn't want the bots to go green, then commit to main, have the PR silently break, and then we merge thinking all was good, but actually not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev_meeting Topic to be discussed at the next dev meeting discussion For talking about potential improvements & changes. gha-buildbots
Projects
None yet
Development

No branches or pull requests

2 participants