Skip to content

Commit 849be49

Browse files
authored
Add --remove-orphans to the deploy step (#368)
docker compose up -d alone leaves containers running for services that were removed from docker-compose.yml -- it only affects services still defined in the file. This is exactly what happened when #367 dropped the pypi/netmon services: their containers kept running untouched (netmon crash-looping) until a reboot surfaced it, at which point they just came back via each container's own restart policy. --remove-orphans makes 'docker compose up -d' actually reconcile to match the file.
1 parent 4cd0e46 commit 849be49

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/validations.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,4 @@ jobs:
109109
if git diff --name-only "$BEFORE" "$AFTER" | grep -qE '^(master/|master\.sh|pyproject\.toml|uv\.lock)'; then
110110
BUILD_FLAG="--build"
111111
fi
112-
docker compose up -d $BUILD_FLAG
112+
docker compose up -d --remove-orphans $BUILD_FLAG

0 commit comments

Comments
 (0)