review feedback

Author: jakewski

Diff for: .vscode/launch.json

@@ -0,0 +1,23 @@
+{
+    "version": "0.2.0",
+    "configurations": [
+      {
+        "name": "Mocha (Test single file)",
+        "type": "node",
+        "request": "launch",
+        "env": {
+            "BABEL_ENV": "test"
+        },
+        "runtimeArgs": [
+          "--require",
+          "babel-core/register",
+          "${workspaceRoot}/node_modules/.bin/mocha",
+          "--inspect-brk",
+          "${relativeFile}",
+        ],
+        "console": "integratedTerminal",
+        "internalConsoleOptions": "neverOpen",
+        "port": 9229
+      }
+    ]
+}

Diff for: README.md

@@ -27,12 +27,12 @@ NOTE: the default `mixpanel-browser` bundle includes a bundled `mixpanel-recorde
 
 To load the main SDK with no option of session recording:
 ```javascript
-var mixpanel = require('mixpanel-browser/dist/mixpanel-main.cjs')
+import mixpanel from 'mixpanel-browser/src/loaders/loader-module-core';
 ```
 
 To load the main SDK and optionally load session recording bundle asynchronously (via script tag):
 ```javascript
-var mixpanel = require('mixpanel-browser/dist/mixpanel-bundle-async.cjs')
+import mixpanel from 'mixpanel-browser/src/loaders/loader-module-with-async-recorder';
 ```
 
 ## Alternative installation via Bower

Diff for: build.sh

@@ -27,8 +27,8 @@ if [ ! -z "$FULL" ]; then
     echo 'Building module bundles'
     npx rollup -i src/loaders/loader-module.js -f amd -o build/mixpanel.amd.js -c rollup.config.js
     npx rollup -i src/loaders/loader-module.js -f cjs -o build/mixpanel.cjs.js -c rollup.config.js
-    npx rollup -i src/loaders/loader-module-main.js -f cjs -o build/mixpanel-main.cjs.js -c rollup.config.js
-    npx rollup -i src/loaders/loader-module-bundle-async.js -f cjs -o build/mixpanel-bundle-async.cjs.js -c rollup.config.js
+    npx rollup -i src/loaders/loader-module-core.js -f cjs -o build/mixpanel-core.cjs.js -c rollup.config.js
+    npx rollup -i src/loaders/loader-module-with-async-recorder.js -f cjs -o build/mixpanel-with-async-recorder.cjs.js -c rollup.config.js
     npx rollup -i src/loaders/loader-module.js -f umd -o build/mixpanel.umd.js -n mixpanel -c rollup.config.js
 
     echo 'Bundling module-loader test runners'