Skip to content

Do not pre-check "enhancement" checkbox for port updates in PR template #353

Description

@suhailskhan

The pull request template (seaport/_pull_request/pull_request.py) currently has the "enhancement" checkbox checked by default (- [x] enhancement). For port updates, the MacPorts bot automatically adds an "update" label. Having the enhancement box pre-checked causes an extra "enhancement" label to be applied to PRs that are only port updates, which is redundant and can be misleading.

Location: seaport/_pull_request/pull_request.py (commit 8bb98ae) Current line: - [x] enhancement

Steps to reproduce:

  • Open a pull request that only updates a port (version bump, port metadata, etc.).
  • Observe the MacPorts bot automatically adds the "update" label.
  • Observe the PR template renders with "enhancement" already checked, which results in an additional "enhancement" label.

Actual behavior: Port update PRs end up labeled both "update" (from the bot) and "enhancement" (from the pre-checked box), creating redundant/misleading labeling.

Expected behavior: Checkboxes in the PR template should be unchecked by default. The "enhancement" box should only be checked when the PR truly implements a feature or enhancement. For port updates, rely on the MacPorts bot to add the "update" label and avoid pre-checking "enhancement".

Suggested fix:

  • Replace - [x] enhancement with - [ ] enhancement so it is unchecked by default.

Proposed minimal patch:

Change:

  • enhancement

to:

  • enhancement

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions