Polish developer documentation#29
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Documentation-focused cleanup that tightens wording across README/ARCHITECTURE/DocC and refines inline source comments to better describe SwiftVLC’s behavior (discovery/renderers, PiP, typed errors, concurrency, logging, etc.) without changing runtime logic.
Changes:
- Reword DocC articles and README sections for clearer, more precise descriptions (metadata, discovery/casting, concurrency model, PiP, CI/testing claims, VLCKit comparison).
- Polish/trim inline comments across core types (Player, EventBridge, Logging/LogNoiseFilter, playlists, PiP, thumbnails).
- Update architecture documentation to reflect current internal components (e.g., Broadcaster-based fan-out, LogBroadcaster naming).
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/SwiftVLC/Video/Marquee.swift | Comment wording tweak around freetype cache-busting behavior. |
| Sources/SwiftVLC/SwiftVLC.docc/WorkingWithMedia.md | Clarifies typed vs subscripted metadata access. |
| Sources/SwiftVLC/SwiftVLC.docc/SwiftVLC.md | Adjusts phrasing for typed errors and CI cadence claims. |
| Sources/SwiftVLC/SwiftVLC.docc/PlaybackEssentials.md | Refines deinit/off-main teardown explanation. |
| Sources/SwiftVLC/SwiftVLC.docc/DiscoveryAndCasting.md | Reframes discovery/casting docs around libVLC plugins/services. |
| Sources/SwiftVLC/SwiftVLC.docc/ConcurrencyModel.md | Clarifies sending ownership-transfer explanation. |
| Sources/SwiftVLC/SwiftVLC.docc/ComparisonWithVLCKit.md | Updates comparison wording/tables to focus on documented install surfaces and platform targets. |
| Sources/SwiftVLC/SwiftVLC.docc/AudioFeatures.md | Refines equalizer/role-hint descriptions and guidance. |
| Sources/SwiftVLC/Playlist/MediaListPlayer.swift | Comment wording: “raw toggle” phrasing. |
| Sources/SwiftVLC/Playlist/MediaList.swift | Comment wording cleanup for media-at-index accessor. |
| Sources/SwiftVLC/Player/PlayerRole.swift | Improves doc comment to describe libVLC backend forwarding semantics. |
| Sources/SwiftVLC/Player/PlayerEvent.swift | Refines corked/uncorked event descriptions. |
| Sources/SwiftVLC/Player/Player+Programs.swift | Narrows renderer wording and section labels. |
| Sources/SwiftVLC/Player/Player+Events.swift | Generalizes examples of external state changes triggering SwiftUI updates. |
| Sources/SwiftVLC/Player/Player.swift | Comment wording updates (marquee cache, drawable lifetime, sending, pause-toggle hazard). |
| Sources/SwiftVLC/Player/EventBridge.swift | Comment wording around “previous UIView” and reattachment rationale. |
| Sources/SwiftVLC/PiP/PiPVideoView+MacPrivate.swift | Trims rationale comment for private macOS PiP backend. |
| Sources/SwiftVLC/PiP/PiPController.swift | Comment wording improvements (state sync window, debounce self-binding, testing hook). |
| Sources/SwiftVLC/Media/Track.swift | Simplifies codec FourCC comment. |
| Sources/SwiftVLC/Media/ThumbnailRequest.swift | Tightens seek-mode description and coordinator-release rationale comment. |
| Sources/SwiftVLC/Media/Metadata.swift | Aligns Metadata doc comment with “common keys” phrasing. |
| Sources/SwiftVLC/Media/Media.swift | Trims mediaType timing details; simplifies addSlave priority wording. |
| Sources/SwiftVLC/Discovery/RendererDiscoverer.swift | Rewords renderer discovery docs to plugin-based phrasing. |
| Sources/SwiftVLC/Core/VLCInstance.swift | Minor wording tweak (“ensure” vs “guarantee”). |
| Sources/SwiftVLC/Core/LogNoiseFilter.swift | Trims/clarifies filter invariants and intent. |
| Sources/SwiftVLC/Core/Logging.swift | Comment tweak explaining the BroadcasterBox workaround. |
| Sources/SwiftVLC/Core/Broadcaster.swift | Comment tweak clarifying terminate vs finishAll guidance. |
| scripts/build-libvlc.sh | Comment wording updates for toolchain-related build patches. |
| README.md | Rewords motivation/comparison/features/testing/build-notes/acknowledgments sections. |
| Package.swift | Clarifies why CLibVLC is not re-linked in tests (duplicate ObjC classes). |
| ARCHITECTURE.md | Updates component naming/descriptions (LogBroadcaster/EventBridge/Broadcaster), CI workflow descriptions, and repo layout notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation