Skip to content

Polish developer documentation#29

Merged
omaralbeik merged 1 commit into
mainfrom
docs
May 5, 2026
Merged

Polish developer documentation#29
omaralbeik merged 1 commit into
mainfrom
docs

Conversation

@omaralbeik
Copy link
Copy Markdown
Member

Summary

  • Tighten README, architecture, and DocC wording around VLCKit comparison, discovery/renderers, PiP, CI, release, and build claims.
  • Remove stale or transitional source comments while preserving behavior.
  • Validate relative Markdown links and DocC generation after the cleanup.

Validation

  • git diff --check
  • swiftformat Sources/SwiftVLC Package.swift --lint --strict
  • ./scripts/doc-coverage.sh --json
  • swift package --disable-sandbox generate-documentation --target SwiftVLC
  • relative Markdown link check across README, ARCHITECTURE, and DocC files

Copilot AI review requested due to automatic review settings May 5, 2026 13:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation-focused cleanup that tightens wording across README/ARCHITECTURE/DocC and refines inline source comments to better describe SwiftVLC’s behavior (discovery/renderers, PiP, typed errors, concurrency, logging, etc.) without changing runtime logic.

Changes:

  • Reword DocC articles and README sections for clearer, more precise descriptions (metadata, discovery/casting, concurrency model, PiP, CI/testing claims, VLCKit comparison).
  • Polish/trim inline comments across core types (Player, EventBridge, Logging/LogNoiseFilter, playlists, PiP, thumbnails).
  • Update architecture documentation to reflect current internal components (e.g., Broadcaster-based fan-out, LogBroadcaster naming).

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Sources/SwiftVLC/Video/Marquee.swift Comment wording tweak around freetype cache-busting behavior.
Sources/SwiftVLC/SwiftVLC.docc/WorkingWithMedia.md Clarifies typed vs subscripted metadata access.
Sources/SwiftVLC/SwiftVLC.docc/SwiftVLC.md Adjusts phrasing for typed errors and CI cadence claims.
Sources/SwiftVLC/SwiftVLC.docc/PlaybackEssentials.md Refines deinit/off-main teardown explanation.
Sources/SwiftVLC/SwiftVLC.docc/DiscoveryAndCasting.md Reframes discovery/casting docs around libVLC plugins/services.
Sources/SwiftVLC/SwiftVLC.docc/ConcurrencyModel.md Clarifies sending ownership-transfer explanation.
Sources/SwiftVLC/SwiftVLC.docc/ComparisonWithVLCKit.md Updates comparison wording/tables to focus on documented install surfaces and platform targets.
Sources/SwiftVLC/SwiftVLC.docc/AudioFeatures.md Refines equalizer/role-hint descriptions and guidance.
Sources/SwiftVLC/Playlist/MediaListPlayer.swift Comment wording: “raw toggle” phrasing.
Sources/SwiftVLC/Playlist/MediaList.swift Comment wording cleanup for media-at-index accessor.
Sources/SwiftVLC/Player/PlayerRole.swift Improves doc comment to describe libVLC backend forwarding semantics.
Sources/SwiftVLC/Player/PlayerEvent.swift Refines corked/uncorked event descriptions.
Sources/SwiftVLC/Player/Player+Programs.swift Narrows renderer wording and section labels.
Sources/SwiftVLC/Player/Player+Events.swift Generalizes examples of external state changes triggering SwiftUI updates.
Sources/SwiftVLC/Player/Player.swift Comment wording updates (marquee cache, drawable lifetime, sending, pause-toggle hazard).
Sources/SwiftVLC/Player/EventBridge.swift Comment wording around “previous UIView” and reattachment rationale.
Sources/SwiftVLC/PiP/PiPVideoView+MacPrivate.swift Trims rationale comment for private macOS PiP backend.
Sources/SwiftVLC/PiP/PiPController.swift Comment wording improvements (state sync window, debounce self-binding, testing hook).
Sources/SwiftVLC/Media/Track.swift Simplifies codec FourCC comment.
Sources/SwiftVLC/Media/ThumbnailRequest.swift Tightens seek-mode description and coordinator-release rationale comment.
Sources/SwiftVLC/Media/Metadata.swift Aligns Metadata doc comment with “common keys” phrasing.
Sources/SwiftVLC/Media/Media.swift Trims mediaType timing details; simplifies addSlave priority wording.
Sources/SwiftVLC/Discovery/RendererDiscoverer.swift Rewords renderer discovery docs to plugin-based phrasing.
Sources/SwiftVLC/Core/VLCInstance.swift Minor wording tweak (“ensure” vs “guarantee”).
Sources/SwiftVLC/Core/LogNoiseFilter.swift Trims/clarifies filter invariants and intent.
Sources/SwiftVLC/Core/Logging.swift Comment tweak explaining the BroadcasterBox workaround.
Sources/SwiftVLC/Core/Broadcaster.swift Comment tweak clarifying terminate vs finishAll guidance.
scripts/build-libvlc.sh Comment wording updates for toolchain-related build patches.
README.md Rewords motivation/comparison/features/testing/build-notes/acknowledgments sections.
Package.swift Clarifies why CLibVLC is not re-linked in tests (duplicate ObjC classes).
ARCHITECTURE.md Updates component naming/descriptions (LogBroadcaster/EventBridge/Broadcaster), CI workflow descriptions, and repo layout notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@omaralbeik omaralbeik merged commit 0c86d84 into main May 5, 2026
13 checks passed
@omaralbeik omaralbeik deleted the docs branch May 5, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants