create_comment works only in review pannel

[mrparalon]

On the latest version of plugin, .create_comment() works only from review panel.

Error message Delta reviewer must be initialized first

I'm using diffview to review MRs.

Is it possible to make it work without Delta reviewer?

[harrisoncramer]

This is by design. The reason is because we need to get the current line information from the reviewer in order to make a comment to Github's APIs.

Please see this discussion for more context: #25

If we want to add a reviewer, it would have to implement the functions at lua/gitlab/reviewer/init.lua

-- This Module will pick the reviewer set in the user's
-- settings and then map all of it's functions
local state = require("gitlab.state")
local delta = require("gitlab.reviewer.delta")

local M = {
  reviewer = nil,
}

local reviewer_map = {
  delta = delta
}

M.init = function()
  local reviewer = reviewer_map[state.settings.reviewer]
  if reviewer == nil then
    vim.notify(string.format("gitlab.nvim could not find reviewer %s", state.settings.reviewer), vim.log.levels.ERROR)
    return
  end

  M.open = reviewer.open
  -- Opens the reviewer window

  M.jump = reviewer.jump
  -- Jumps to the location provided in the reviewer window
  -- Parameters:
  --   • {file_name}      The name of the file to jump to
  --   • {new_line}  The new_line of the change
  --   • {interval}  The old_line of the change

  M.get_location = reviewer.get_location
  -- Returns the current location (based on cursor) from the reviewer window (file_name, line_numbers, error) where line_numbers is a lua table like this: { old_line: old_line_num, new_line: new_line_num }
end

return M

These functions pull information from the current buffer and pass it to the comment module, which will send the comment to Gitlab. I'm intending to work on supporting Diffview (this is the reviewer that I've used in the past as well) but haven't gotten to it yet.

[mrparalon]

Thanks for direction, I'll try to add diffview reviewer