Skip to content

Feat: Automatically Detect Stale Branches #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harrisoncramer opened this issue Sep 9, 2023 · 0 comments
Closed

Feat: Automatically Detect Stale Branches #60

harrisoncramer opened this issue Sep 9, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@harrisoncramer
Copy link
Owner

harrisoncramer commented Sep 9, 2023

As pointed out by @levouh here #25 (comment)

It'd be best if this library could detect when your current or target branch is out of date. I'm thinking that the best solution here is to prompt you to re-pull those branches to your local system prior to running the reviewer. Then you could get a prompt popup (You are out of date, would you like to pull down those branches?) and then the reviewer would do this automatically.

There could be some complexity if either pull fails (for instance if you have to rebase on either branch). However in those cases we could probably just prompt the user to pull down manually.

Running the reviewer against the remote branches directly is overly complex because it would likely involve comparing against temporary buffers and would break the basic functionality of how both Delta and Diffview currently work.

@harrisoncramer harrisoncramer changed the title Au Feat: Automatically Detect Stale Branches Sep 9, 2023
@harrisoncramer harrisoncramer added the feature request New feature or request label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant