Skip to content

Orphan instances detection in haskell-process-trigger-suggestions is outdated #1110

Open
@geraldus

Description

@geraldus

I can't be certain, but it looks like orphan instance warning have changed in recent versions of GHC. Currently haskell-process-trigger-suggestions function uses following regex to detect orphan instance warnings in compiler response "Warning: orphan instance: " [1], while GHC 7.10.3 gives a bit different formatting:

/Users/oman/dev/haskell/sol/solitaire/src/Solitaire.hs:12:10: Warning:
    Orphan instance: instance Show Layer
    To avoid this
        move the instance declaration to the module of the class or of the type, or
        wrap the type with a newtype and declare the instance on the new type.

As a result, haskell-process-trigger-suggestions does not suggest to add OPTIONS pragma as intended.

@gracjan I know we need tests for this function, it's quite big and good test suite should rely on genuine GHC response, what will you say?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions