Integrate SonarLint suggestions in AoC 2017 solutions

Author: hb20007

advent-of-code/2017/day-01/test.js

@@ -5,41 +5,41 @@ const partTwo = require('./partTwo');
 describe('Day 1: Inverse Captcha', () => {
   describe('Part 1', () => {
     it('should evaluate captcha 1122', () => {
-      assert.equal(3, partOne([1, 1, 2, 2]));
+      assert.strictEqual(3, partOne([1, 1, 2, 2]));
     });
 
     it('should evaluate captcha 1111', () => {
-      assert.equal(4, partOne([1, 1, 1, 1]));
+      assert.strictEqual(4, partOne([1, 1, 1, 1]));
     });
 
     it('should evaluate captcha 1234', () => {
-      assert.equal(0, partOne([1, 2, 3, 4]));
+      assert.strictEqual(0, partOne([1, 2, 3, 4]));
     });
 
     it('should evaluate captcha 91212129', () => {
-      assert.equal(9, partOne([9, 1, 2, 1, 2, 1, 2, 9]));
+      assert.strictEqual(9, partOne([9, 1, 2, 1, 2, 1, 2, 9]));
     });
   });
 
   describe('Part 2', () => {
     it('should evaluate captcha 1212', () => {
-      assert.equal(6, partTwo([1, 2, 1, 2]));
+      assert.strictEqual(6, partTwo([1, 2, 1, 2]));
     });
 
     it('should evaluate captcha 1221', () => {
-      assert.equal(0, partTwo([1, 2, 2, 1]));
+      assert.strictEqual(0, partTwo([1, 2, 2, 1]));
     });
 
     it('should evaluate captcha 123425', () => {
-      assert.equal(4, partTwo([1, 2, 3, 4, 2, 5]));
+      assert.strictEqual(4, partTwo([1, 2, 3, 4, 2, 5]));
     });
 
     it('should evaluate captcha 123123', () => {
-      assert.equal(12, partTwo([1, 2, 3, 1, 2, 3]));
+      assert.strictEqual(12, partTwo([1, 2, 3, 1, 2, 3]));
     });
 
     it('should evaluate captcha 12131415', () => {
-      assert.equal(4, partTwo([1, 2, 1, 3, 1, 4, 1, 5]));
+      assert.strictEqual(4, partTwo([1, 2, 1, 3, 1, 4, 1, 5]));
     });
   });
 });

advent-of-code/2017/day-02/partTwo.js

@@ -1,11 +1,11 @@
 /* eslint array-callback-return: "off", consistent-return: "off" */
 const partTwo = (rows) => rows.reduce((checksum, row) => {
-  for (let i = 0; i < row.length; i++) {
-    const candidates = row.filter((x) => x < row[i]);
+  for (const number of row) {
+    const candidates = row.filter((x) => x < number);
 
-    for (let j = 0; j < candidates.length; j++) {
-      if (row[i] % candidates[j] === 0) {
-        return checksum + row[i] / candidates[j];
+    for (const candidate of candidates) {
+      if (number % candidate === 0) {
+        return checksum + number / candidate;
       }
     }
   }

advent-of-code/2017/day-02/test.js

@@ -7,15 +7,15 @@ describe('Day 2: Corruption Checksum', () => {
     it('should calculate checksum as 18', () => {
       const SPREADSHEET = [[5, 1, 9, 5], [7, 5, 3], [2, 4, 6, 8]];
 
-      assert.equal(18, partOne(SPREADSHEET));
+      assert.strictEqual(18, partOne(SPREADSHEET));
     });
   });
 
   describe('Part 2', () => {
     it('should calculate second checksum as 9', () => {
       const SPREADSHEET = [[5, 9, 2, 8], [9, 4, 7, 3], [3, 8, 6, 5]];
 
-      assert.equal(9, partTwo(SPREADSHEET));
+      assert.strictEqual(9, partTwo(SPREADSHEET));
     });
   });
 });

advent-of-code/2017/day-03/test.js

@@ -5,29 +5,29 @@ const partTwo = require('./partTwo');
 describe('Day 3: Spiral Memory', () => {
   describe('Part 1', () => {
     it('should calculate steps for square 1', () => {
-      assert.equal(0, partOne(1));
+      assert.strictEqual(0, partOne(1));
     });
 
     it('should calculate steps for square 12', () => {
-      assert.equal(3, partOne(12));
+      assert.strictEqual(3, partOne(12));
     });
 
     it('should calculate steps for square 23', () => {
-      assert.equal(2, partOne(23));
+      assert.strictEqual(2, partOne(23));
     });
 
     it('should calculate steps for square 1024', () => {
-      assert.equal(31, partOne(1024));
+      assert.strictEqual(31, partOne(1024));
     });
   });
 
   describe('Part 2', () => {
     it('should calculate the first value in the sequence larger than 10', () => {
-      assert.equal(11, partTwo(10));
+      assert.strictEqual(11, partTwo(10));
     });
 
     it('should calculate the first value in the sequence larger than 59', () => {
-      assert.equal(122, partTwo(59));
+      assert.strictEqual(122, partTwo(59));
     });
   });
 });

advent-of-code/2017/day-04/test.js

@@ -11,7 +11,7 @@ describe('Day 4: High-Entropy Passphrases', () => {
         ['aa', 'bb', 'cc', 'dd', 'aaa']
       ];
 
-      assert.equal(2, partOne(PASSPHRASES));
+      assert.strictEqual(2, partOne(PASSPHRASES));
     });
   });
 
@@ -25,7 +25,7 @@ describe('Day 4: High-Entropy Passphrases', () => {
         ['oiii', 'ioii', 'iioi', 'iiio']
       ];
 
-      assert.equal(3, partTwo(PASSPHRASES));
+      assert.strictEqual(3, partTwo(PASSPHRASES));
     });
   });
 });

advent-of-code/2017/day-05/test.js

@@ -7,13 +7,13 @@ describe('Day 5: A Maze of Twisty Trampolines, All Alike', () => {
 
   describe('Part 1', () => {
     it('should calculate 5 steps needed', () => {
-      assert.equal(5, partOne(OFFSETS));
+      assert.strictEqual(5, partOne(OFFSETS));
     });
   });
 
   describe('Part 2', () => {
     it('should calculate 10 steps needed', () => {
-      assert.equal(10, partTwo(OFFSETS));
+      assert.strictEqual(10, partTwo(OFFSETS));
     });
   });
 });

advent-of-code/2017/day-06/test.js

@@ -7,13 +7,13 @@ describe('Day 6: Memory Reallocation', () => {
 
   describe('Part 1', () => {
     it('should calculate 5 steps', () => {
-      assert.equal(partOne(BANKS), 5);
+      assert.strictEqual(partOne(BANKS), 5);
     });
   });
 
   describe('Part Two', () => {
     it('should calculate loop size 4', () => {
-      assert.equal(partTwo(BANKS), 4);
+      assert.strictEqual(partTwo(BANKS), 4);
     });
   });
 });