Merge #196: cmake: Adjust build option defaults

b1b4977 cmake: Make `BUILD_<util>` defaults dependent on `BUILD_TESTS` (Hennadii Stepanov)
9f55197 cmake: Disable by default `BUILD_BENCH` and `BUILD_FUZZ_BINARY` (Hennadii Stepanov)

Pull request description:

  This PR adjusts build option defaults per the discussion during today's call.

ACKs for top commit:
  theuni:
    ACK b1b4977

Tree-SHA512: d21b4c087f881ed913239557056d81780edf9c51a5416eaf511737f6af27f835443790d15752a4858851f43762674e5a7ed0412afd48f5026b266530d7223a09

Author: hebasto

.github/workflows/ci.yml

@@ -188,7 +188,7 @@ jobs:
 
       - name: Generate build system
         run: |
-          cmake -B build --preset vs2022 -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_INSTALLATION_ROOT\scripts\buildsystems\vcpkg.cmake" -DWERROR=ON
+          cmake -B build --preset vs2022 -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_INSTALLATION_ROOT\scripts\buildsystems\vcpkg.cmake" -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DWERROR=ON
 
       - name: Save vcpkg binary cache
         uses: actions/cache/save@v4

CMakeLists.txt

@@ -65,8 +65,11 @@ include(CMakeDependentOption)
 option(BUILD_DAEMON "Build bitcoind executable." ON)
 option(BUILD_GUI "Build bitcoin-qt executable." OFF)
 option(BUILD_CLI "Build bitcoin-cli executable." ON)
-option(BUILD_TX "Build bitcoin-tx executable." ON)
-option(BUILD_UTIL "Build bitcoin-util executable." ON)
+
+option(BUILD_TESTS "Build test_bitcoin executable." ON)
+option(BUILD_TX "Build bitcoin-tx executable." ${BUILD_TESTS})
+option(BUILD_UTIL "Build bitcoin-util executable." ${BUILD_TESTS})
+
 option(BUILD_UTIL_CHAINSTATE "Build experimental bitcoin-chainstate executable." OFF)
 option(BUILD_KERNEL_LIB "Build experimental bitcoinkernel library." ${BUILD_UTIL_CHAINSTATE})
 
@@ -99,7 +102,7 @@ if(WITH_BDB)
     endif()
   endif()
 endif()
-cmake_dependent_option(BUILD_WALLET_TOOL "Build bitcoin-wallet tool." ON "ENABLE_WALLET" OFF)
+cmake_dependent_option(BUILD_WALLET_TOOL "Build bitcoin-wallet tool." ${BUILD_TESTS} "ENABLE_WALLET" OFF)
 
 option(ENABLE_THREADLOCAL "Enable features that depend on the C++ thread_local keyword (currently just thread names in debug logs)." ON)
 option(ENABLE_HARDENING "Attempt to harden the resulting executables." ON)
@@ -160,10 +163,9 @@ if(WITH_MULTIPROCESS)
   find_package(LibmultiprocessGen CONFIG REQUIRED)
 endif()
 
-option(BUILD_TESTS "Build test_bitcoin executable." ON)
 cmake_dependent_option(BUILD_GUI_TESTS "Build test_bitcoin-qt executable." ON "BUILD_GUI;BUILD_TESTS" OFF)
-option(BUILD_BENCH "Build bench_bitcoin executable." ON)
-option(BUILD_FUZZ_BINARY "Build fuzz binary." ON)
+option(BUILD_BENCH "Build bench_bitcoin executable." OFF)
+option(BUILD_FUZZ_BINARY "Build fuzz binary." OFF)
 cmake_dependent_option(ENABLE_FUZZ "Build for fuzzing. Enabling this will disable all other targets and override BUILD_FUZZ_BINARY." OFF "NOT MSVC" OFF)
 
 option(INSTALL_MAN "Install man pages." ON)

CMakePresets.json

@@ -6,6 +6,8 @@
       "name": "ci-common",
       "hidden": true,
       "cacheVariables": {
+        "BUILD_BENCH": "ON",
+        "BUILD_FUZZ_BINARY": "ON",
         "ENABLE_WALLET": "ON",
         "WITH_SQLITE": "ON",
         "WITH_BDB": "ON",

ci/test/03_test_script.sh

@@ -99,7 +99,7 @@ if [ "$DOWNLOAD_PREVIOUS_RELEASES" = "true" ]; then
   test/get_previous_releases.py -b -t "$PREVIOUS_RELEASES_DIR"
 fi
 
-BITCOIN_CONFIG_ALL=""
+BITCOIN_CONFIG_ALL="-DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON"
 if [ -z "$NO_DEPENDS" ]; then
   BITCOIN_CONFIG_ALL="${BITCOIN_CONFIG_ALL} -DCMAKE_TOOLCHAIN_FILE=$DEPENDS_DIR/$HOST/toolchain.cmake"
 fi