cmake: Add WERROR option

Author: hebasto

CMakeLists.txt

@@ -55,6 +55,7 @@ cmake_dependent_option(CXX20 "Enable compilation in C++20 mode." OFF "NOT MSVC"
 option(THREADLOCAL "Enable features that depend on the C++ thread_local keyword (currently just thread names in debug logs)." ON)
 option(HARDENING "Attempt to harden the resulting executables." ON)
 option(REDUCE_EXPORTS "Attempt to reduce exported symbols in the resulting executables." OFF)
+option(WERROR "Treat compiler warnings as errors." OFF)
 
 tristate_option(CCACHE "Use ccache for compiling." "if ccache is found." AUTO)
 tristate_option(WITH_NATPMP "Enable NAT-PMP." "if libnatpmp is found." AUTO)
@@ -305,6 +306,21 @@ if(REDUCE_EXPORTS)
   try_append_linker_flag(core "-Wl,--exclude-libs,ALL")
 endif()
 
+if(WERROR)
+  if(MSVC)
+    target_compile_options(core INTERFACE /WX)
+  else()
+    set(error_cxx_flags)
+    try_append_cxxflag(error_cxx_flags "-Werror")
+    if(NOT CXX_SUPPORTS_WERROR)
+      message(FATAL_ERROR "WERROR set but -Werror is not usable.")
+    endif()
+    separate_arguments(error_cxx_flags)
+    target_compile_options(core INTERFACE ${error_cxx_flags})
+    unset(error_cxx_flags)
+  endif()
+endif()
+
 find_package(Python3 3.8 COMPONENTS Interpreter)
 set(PYTHON_COMMAND ${Python3_EXECUTABLE})
 
@@ -372,6 +388,7 @@ message("Linker flags for shared libraries ..... ${CMAKE_SHARED_LINKER_FLAGS}")
 print_config_flags()
 message("Use assembly routines ................. ${ASM}")
 message("Attempt to harden executables ......... ${HARDENING}")
+message("Treat compiler warnings as errors ..... ${WERROR}")
 message("Use ccache for compiling .............. ${CCACHE}")
 message("\n")
 if(configure_warnings)