Skip to content

Commit 6c2be70

Browse files
committed
Merge #206: cmake: Disable EXPORT_COMPILE_COMMANDS for all subtree targets
a37b0df fixup! cmake: Build `secp256k1` static library (Hennadii Stepanov) 4883df5 fixup! cmake: Build `crc32c` static library (Hennadii Stepanov) Pull request description: Fixes the second point from bitcoin#29790 (comment): > 2. Missed disabling `EXPORT_COMPILE_COMMANDS` property for targets in the `crc32c` subtree. Top commit has no ACKs. Tree-SHA512: 231cda1190faab44f0b0ec72de1ed4abd0f490026c781b26d9ea374995db0d5d00d575c23e8775057a1c59ee1fbf7dcb0b58109ead3051c1ee23e243d852524d
2 parents 23a084e + a37b0df commit 6c2be70

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

cmake/crc32c.cmake

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ target_include_directories(crc32c
9696
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src/crc32c/include>
9797
)
9898
target_link_libraries(crc32c PRIVATE crc32c_common)
99+
set_target_properties(crc32c PROPERTIES EXPORT_COMPILE_COMMANDS OFF)
99100

100101
if(HAVE_SSE42)
101102
add_library(crc32c_sse42 STATIC EXCLUDE_FROM_ALL
@@ -104,6 +105,7 @@ if(HAVE_SSE42)
104105
target_compile_definitions(crc32c_sse42 PUBLIC HAVE_SSE42=1)
105106
target_compile_options(crc32c_sse42 PRIVATE ${SSE42_CXXFLAGS})
106107
target_link_libraries(crc32c_sse42 PRIVATE crc32c_common)
108+
set_target_properties(crc32c_sse42 PROPERTIES EXPORT_COMPILE_COMMANDS OFF)
107109
target_link_libraries(crc32c PRIVATE crc32c_sse42)
108110
endif()
109111

@@ -114,5 +116,6 @@ if(HAVE_ARM64_CRC32C)
114116
target_compile_definitions(crc32c_arm64 PUBLIC HAVE_ARM64_CRC32C=1)
115117
target_compile_options(crc32c_arm64 PRIVATE ${ARM64_CRC_CXXFLAGS})
116118
target_link_libraries(crc32c_arm64 PRIVATE crc32c_common)
119+
set_target_properties(crc32c_arm64 PROPERTIES EXPORT_COMPILE_COMMANDS OFF)
117120
target_link_libraries(crc32c PRIVATE crc32c_arm64)
118121
endif()

cmake/secp256k1.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,3 +57,4 @@ if(MSVC)
5757
endif()
5858

5959
target_link_libraries(secp256k1 PRIVATE core_base_interface)
60+
set_target_properties(secp256k1 PROPERTIES EXPORT_COMPILE_COMMANDS OFF)

0 commit comments

Comments
 (0)