Skip to content

Commit f4b3a58

Browse files
committed
Merge bitcoin#32064: build: Remove manpages when making MacOS app
80b5e7f build: Remove manpages when making MacOS app (Ava Chow) Pull request description: When creating the MacOS app, the only file that should be in `Bitcoin-Qt.app/Contents/MacOS` is `Bitcoin-Qt`. Since bitcoin#31844, there was also a `share/` containing the manpage for bitcoin-qt. This manpage is not useful to app users, and it is also causing code signing issues. Thus the directory should be removed when making the app. Fixes bitcoin#32052 (comment) ACKs for top commit: fanquake: ACK 80b5e7f Tree-SHA512: fd15b7f99737484e40d31c583e01acc7470d038b0c584dfaefecc740811565ceee048913b6e5e37e7935b74d8100dc8323aed3f69d9a6baa5f434754009eb18c
2 parents 92f553e + 80b5e7f commit f4b3a58

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

cmake/module/Maintenance.cmake

+1
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ function(add_macos_deploy_target)
8383
COMMAND ${CMAKE_COMMAND} --install ${PROJECT_BINARY_DIR} --config $<CONFIG> --component bitcoin-qt --prefix ${macos_app}/Contents/MacOS --strip
8484
COMMAND ${CMAKE_COMMAND} -E rename ${macos_app}/Contents/MacOS/bin/$<TARGET_FILE_NAME:bitcoin-qt> ${macos_app}/Contents/MacOS/Bitcoin-Qt
8585
COMMAND ${CMAKE_COMMAND} -E rm -rf ${macos_app}/Contents/MacOS/bin
86+
COMMAND ${CMAKE_COMMAND} -E rm -rf ${macos_app}/Contents/MacOS/share
8687
VERBATIM
8788
)
8889

0 commit comments

Comments
 (0)