Skip to content

Commit 62468fe

Browse files
achow101hebasto
authored andcommitted
wallet, tests: Avoid stringop-overflow warning in PollutePubKey
1 parent be23a6e commit 62468fe

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/wallet/test/wallet_tests.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -498,8 +498,10 @@ static void TestWatchOnlyPubKey(LegacyScriptPubKeyMan* spk_man, const CPubKey& a
498498
// Cryptographically invalidate a PubKey whilst keeping length and first byte
499499
static void PollutePubKey(CPubKey& pubkey)
500500
{
501-
std::vector<unsigned char> pubkey_raw(pubkey.begin(), pubkey.end());
502-
std::fill(pubkey_raw.begin()+1, pubkey_raw.end(), 0);
501+
assert(pubkey.size() >= 1);
502+
std::vector<unsigned char> pubkey_raw;
503+
pubkey_raw.push_back(pubkey[0]);
504+
pubkey_raw.insert(pubkey_raw.end(), pubkey.size() - 1, 0);
503505
pubkey = CPubKey(pubkey_raw);
504506
assert(!pubkey.IsFullyValid());
505507
assert(pubkey.IsValid());

0 commit comments

Comments
 (0)