Default x/X key bindings

[PitiBouchon]

I don't understand the default keybindings of :
x = "extend_line_below" / X = "extend_to_line_bounds"

It is so un-natural and different from the other default keybindings like : f/F, t/T, n/N, o/O where pressing SHIFT kind of do the opposite of the action

Thus, I think it should be changed to :

x = "select_line_below"
X = "select_line_above"

which would feel more natural along the other default keybindings, and easier for beginner to use

[rahil627]

i agree. i don't even remember the point.. doesn't pressing x basically do extend_to_line_bounds upon the first press?

maybe c-x/c-s-x for extend/shrink parent node instead?

also the default a-x = shrink... doesn't make sense.

[ck961018]

I agree too.
The function of X can be completely covered by x.
And when I want to select line above, I have to type "xv<a-;> k", which is too cumbersome.

[nikitarevenco]

this would make total sense as a default, +1

[WolfEYc]

I already have this for my keybindings as well.

[nikitarevenco]

pull request: #12013

[EmiOnGit]

Hey!
I am the author of select_line_below/above and think it's pretty cool that people also enjoy the functionality.
Personally, I bound them to J,K instead of x,X and think it's even more intuitive!

[PitiBouchon]

This looks like a good idea 👌

But as J and K are already used for (Join lines and Keep selections) I don't think messing up a lot of default keybindings is a good idea.

The goal of this issue was to simplify and unify the experience for new user that will find a more coherent default keybindings without changing much of these

[EmiOnGit]

Yeah I agree. It's not a change that should be land on Helix itself because it messes up the current keymap.
Just wanted to through it in for people to try out :)

[rahil627]

# idea from 00sapo
x = ["extend_line", "select_mode"] # fantastic mapping, teaches you to use select_mode in the process, allowing precise selection, at the cost of one key to exit
X = ["extend_line", "select_mode", "flip_selections"] # same as the above but prepare for going up by flipping the cursor to the beginning of the selection
C-x = "extend_line_below" # the sane default, press again to extend one more line
C-X = "extend_line_above"
  # matches C-ret/C-ret for adding lines down/up

when I was using helix, I had this binding that's quite interesting, that someone shared in the "share your configs" discussion. though I don't think it should be the default, as it adds an extra button (escape to normal mode), it's worth thinking about. There were many times when I needed to add or subtract a bit of selection, and being in visual mode allowed that. Unfortunately, it's rather one-directional.

I now use meow, a minor mode in doom emacs (sorry helix, but you served as the perfect jump to it <3), a minimalist kakoune-eque mappings, and i really dig the ability to press a number to add a number of lines (in addition to being able to press x again to add a single line). The meow-module also temporarily shows numbered indicators next to each line, so you can visually see what number to press. The indicators are kinda annoying 'n ugly, but it works.. with or without them.

just some thoughts.

but at the minimum, def extend_line_below/above!! can leave extend/shrink_to_parent_node to another key, as it requires tree-sitter, and has a different behavior, though, imo, just as important.