unpack::<N> should fail typecheck on rank-M (M != N) shapes

[statusfailed]

The problem is here:

            // write each result into state at op.targets ids
            for ((node_id, _), result) in ssa.targets.iter().zip(results) {
                on_write(*node_id, &result);
                if state.insert(*node_id, result).is_some() {
                    return Err(InterpreterError::MultipleWrite(*node_id));
                }
            }

Namely: rust's zip is silently truncating one of the iterators.

Fix: insert a length check that there are exactly as many results as targets.

[janimo]

Adding assert_eq!(results.len(), ssa.targets.len()); before that catches a Copy too.

thread 'main' panicked at catgrad/src/abstract_interpreter/eval.rs:60:17:
assertion left == right failed
left: 1
right: 0

[statusfailed]

Adding assert_eq!(results.len(), ssa.targets.len()); before that catches a Copy too.

thread 'main' panicked at catgrad/src/abstract_interpreter/eval.rs:60:17: assertion left == right failed left: 1 right: 0

You mean every Copy is caught, or a specific model is causing this?

[janimo]

Not every copy, at one point when running the llama example (any model, so probably one of the helpers)
[...]
SSA OP: Copy
SSA OP: Copy
SSA OP: Type(Shape)
SSA OP: Type(Unpack)
SSA OP: Tensor(Sum)
SSA OP: Copy
SSA OP: Copy

thread 'main' panicked at catgrad/src/abstract_interpreter/eval.rs:60:17:
assertion left == right failed
left: 1
right: 0

[statusfailed]

The Copy is another bug in the interpreter, line 108 of eval.rs (my bad)