changes

Author: hemanth-1321

server/agentic/agents/aggregator_agent.py

@@ -2,13 +2,11 @@
 from server.agentic.agents.nodes import PRState
 from server.agentic.utils.llm_client import llm
 from server.servcies.github import post_pr_comment, update_pr_comment
-import logging
 
-logger = logging.getLogger(__name__)
 
 def aggregator_agent(state: PRState) -> dict:
 
-    logger.info("aggregator_agent running")
+    print("aggregator_agent running")
 
     security = state.get("security_issues", [])
     quality = state.get("code_quality_issues", [])
@@ -79,7 +77,7 @@ def aggregator_agent(state: PRState) -> dict:
 
 ## Changes
 
-| File(s) | Summary |
+|File(s) | Summary |
 |------------------|---------|
 {chr(10).join(f"| **{file_path.split('/')[-2] if '/' in file_path else 'Root'}** | [Describe changes] |" for file_path in files_changed[:3])}
 | ... | ... |

server/agentic/agents/graph.py

@@ -1,62 +1,28 @@
-from server.agentic.agents.nodes import (
-    fetch_context_agent, code_quality_agent, security_agent,
-    test_agent, performance_agent, PRState, error_handler, with_retry
-)
+from server.agentic.agents.nodes import fetch_context_agent, code_quality_agent, security_agent, test_agent, performance_agent, PRState
 from server.agentic.agents.aggregator_agent import aggregator_agent
 from langgraph.graph import StateGraph, START, END
 
 graph = StateGraph(PRState)
 
-# --- Nodes with error handlers ---
-graph.add_node(
-    "fetch_context_agent",
-    with_retry(fetch_context_agent),
-    on_error=error_handler
-)
+graph.add_node("fetch_context_agent", fetch_context_agent)
+graph.add_node("security_agent", security_agent)
+graph.add_node("code_quality_agent", code_quality_agent)
+graph.add_node("performance_agent", performance_agent)
+graph.add_node("test_agent", test_agent)
+graph.add_node("aggregator_agent", aggregator_agent)
 
-graph.add_node(
-    "security_agent",
-    with_retry(security_agent),
-    on_error=error_handler
-)
-
-graph.add_node(
-    "code_quality_agent",
-    with_retry(code_quality_agent),
-    on_error=error_handler
-)
-
-graph.add_node(
-    "performance_agent",
-    with_retry(performance_agent),
-    on_error=error_handler
-)
-
-graph.add_node(
-    "test_agent",
-    with_retry(test_agent),
-    on_error=error_handler
-)
-
-graph.add_node(
-    "aggregator_agent",
-    with_retry(aggregator_agent),
-    on_error=error_handler
-)
-
-# ---- Graph Edges ----
 graph.add_edge(START, "fetch_context_agent")
 graph.add_edge("fetch_context_agent", "security_agent")
 graph.add_edge("fetch_context_agent", "code_quality_agent")
 graph.add_edge("fetch_context_agent", "performance_agent")
 graph.add_edge("fetch_context_agent", "test_agent")
-
 graph.add_edge("security_agent", "aggregator_agent")
 graph.add_edge("code_quality_agent", "aggregator_agent")
 graph.add_edge("performance_agent", "aggregator_agent")
 graph.add_edge("test_agent", "aggregator_agent")
-
 graph.add_edge("aggregator_agent", END)
 
+
 # Compile workflow
 workflow = graph.compile()
+

server/agentic/agents/nodes.py

@@ -1,12 +1,7 @@
-from typing import TypedDict, List, Annotated, Optional
+from typing import TypedDict, List, Annotated,Optional
 from operator import add
 from server.agentic.utils.llm_client import llm
 from server.agentic.utils.vector_tool import search_vector_tool
-import time
-import traceback
-import logging
-
-logger = logging.getLogger(__name__)
 
 class SimilarPR(TypedDict):
     ref_id: str
@@ -24,63 +19,14 @@ class PRState(TypedDict):
     code_quality_issues: Annotated[List[str], add]
     performance_issues: Annotated[List[str], add]
     test_suggestions: Annotated[List[str], add]
-    commit_sha: int
+    commit_sha:int
     learnings: str
     progress_comment_id: Optional[int]
     final_review: str
     review_complete: bool
-    agent_failed: Optional[str]
-    agent_error: Optional[str]
-    agent_trace: Optional[str]
-
-def with_retry(agent_fn, retries=3, base_delay=1):
-    """
-    Wraps agent nodes with retries + exponential backoff
-    """
-    def wrapper(state: PRState):
-        attempt = 0
-        last_exc = None
-        while attempt < retries:
-            try:
-                logger.info(f"Running {agent_fn.__name__} (Attempt {attempt+1}/{retries})")
-                return agent_fn(state)
-            except Exception as e:
-                last_exc = e
-                delay = base_delay * (2 ** attempt)
-                logger.error(f"Error in {agent_fn.__name__}: {e}")
-                logger.debug(traceback.format_exc())
-                time.sleep(delay)
-                attempt += 1
-        logger.critical(f"{agent_fn.__name__} FAILED after {retries} retries")
-        return {
-            "agent_failed": agent_fn.__name__,
-            "agent_error": str(last_exc),
-            "agent_trace": traceback.format_exc()
-        }
-    return wrapper
-
-
-def error_handler(state: PRState):
-    failed_node = state.get("agent_failed")
-    err = state.get("agent_error")
-
-    logger.critical(f"Global Error Handler Triggered due to: {failed_node}")
-
-    return {
-        "final_review": f"""
-        **Agent Failure Detected**
-
-**Failed Node:** {failed_node}
-**Error:** {err}
-
-Partial review generated from available agents.
-""",
-        "review_complete": True
-    }
-
 
 def fetch_context_agent(state: PRState) -> dict:
-    logger.info("fetch_context_agent running")
+    print("fetch_context_agent running")
     search_query = f"{state.get('pr_number', '')} {state.get('repo_name', '')}"
 
     raw_similar_pr = search_vector_tool(search_query)
@@ -95,11 +41,11 @@ def fetch_context_agent(state: PRState) -> dict:
 
     learnings = "no past-learnig for now"
 
+    # ONLY return the keys you're updating
     return {"similar_prs": similar_pr, "learnings": str(learnings)}
 
-
 def security_agent(state: PRState) -> dict:
-    logger.info("security_agent running")
+    print("security_agent running")
     learnings = state.get("learnings", "")
     context = state.get("similar_prs", [])
 
@@ -123,12 +69,12 @@ def security_agent(state: PRState) -> dict:
 """
     res = llm.invoke(prompt)
     issues = [line.strip() for line in res.content.splitlines() if line.strip()]
-
+    
+    # ONLY return the security_issues key
     return {"security_issues": issues}
 
-
 def code_quality_agent(state: PRState) -> dict:
-    logger.info("code_quality_agent running")
+    print("code_quality_agent running")
     learnings = state.get("learnings", "")
     context = state.get("similar_prs", [])
 
@@ -149,12 +95,12 @@ def code_quality_agent(state: PRState) -> dict:
 """
     res = llm.invoke(prompt)
     issues = [line.strip() for line in res.content.splitlines() if line.strip()]
-
+    
+    # ONLY return the code_quality_issues key
     return {"code_quality_issues": issues}
 
-
 def performance_agent(state: PRState) -> dict:
-    logger.info("performance_agent running")
+    print("performance_agent running")
     learnings = state.get("learnings", "")
     context = state.get("similar_prs", [])
 
@@ -173,12 +119,11 @@ def performance_agent(state: PRState) -> dict:
 """
     res = llm.invoke(prompt)
     issues = [line.strip() for line in res.content.splitlines() if line.strip()]
-
+    
     return {"performance_issues": issues}
 
-
 def test_agent(state: PRState) -> dict:
-    logger.info("test_agent running")
+    print("test_agent running")
     learnings = state.get("learnings", "")
     context = state.get("similar_prs", [])
 
@@ -200,5 +145,5 @@ def test_agent(state: PRState) -> dict:
 """
     res = llm.invoke(prompt)
     issues = [line.strip() for line in res.content.splitlines() if line.strip()]
-
+    
     return {"test_suggestions": issues}