Skip to content

Commit 49810c0

Browse files
authored
Removing UV_USE_IO_URING override (#1376)
* Removing `UV_USE_IO_URING` override This build issue that required these additions ([#1347](#1347), [#1351](#1351)) was addressed by an upgrade to `kernel-6.1.119-129.201.amzn2023` in [this Amazon Linux AMI release](https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes-2023.6.20241212.html). Therefore, these environment overrides are no longer necessary.
1 parent 4930691 commit 49810c0

File tree

6 files changed

+1
-56
lines changed

6 files changed

+1
-56
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## [Unreleased]
44

5+
- Removed `UV_USE_IO_URING` override. ([#1376](https://github.com/heroku/heroku-buildpack-nodejs/pull/1376))
56

67
## [v281] - 2025-02-05
78

bin/compile

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -64,19 +64,6 @@ export PATH="$BUILD_DIR/.heroku/node/bin:$BUILD_DIR/.heroku/yarn/bin":$PATH
6464
export COREPACK_HOME="$BUILD_DIR/.heroku/corepack"
6565
export COREPACK_ENABLE_DOWNLOAD_PROMPT=0
6666

67-
# 2024-11-20:
68-
# We started getting reports on build timeouts on the platform that were unexpected
69-
# due to the specific versions on Node.js and npm which had been working fine up until
70-
# this date. After some extensive digging, we believe we narrowed down the cause to
71-
# a bug in io_uring that affects the Amazon Linux 2023 release. There is a pending fix
72-
# which will be released around Dec. 9th but, until then, the workaround is set disable
73-
# the use of io_uring in libuv.
74-
#
75-
# See https://github.com/npm/cli/issues/7814#issuecomment-2488626736
76-
# → https://github.com/amazonlinux/amazon-linux-2023/issues/840#issuecomment-2485782075
77-
# → https://lore.kernel.org/io-uring/[email protected]/T/#m57570b5f8f2fc00d5a17cfe18ffeeba9fc23a43d
78-
export UV_USE_IO_URING=${UV_USE_IO_URING:-0}
79-
8067
LOG_FILE=$(mktemp -t node-build-log.XXXXX)
8168
echo "" > "$LOG_FILE"
8269

lib/environment.sh

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -108,18 +108,6 @@ write_export() {
108108
echo "export NODE_HOME=\"$build_dir/.heroku/node\"" >> "$bp_dir/export"
109109
# shellcheck disable=SC2016
110110
echo 'export NODE_OPTIONS=${NODE_OPTIONS:-"--max_old_space_size=2560"}' >> "$bp_dir/export"
111-
112-
# 2024-11-21:
113-
# Set UV_USE_IO_URING for later buildpacks to prevent build timeouts when
114-
# running `yarn install` on some Amazon Linux 2023 releases. This may be
115-
# removed in the future when a fixed AL2023 release is available
116-
# (~2024-12-09 or later).
117-
#
118-
# See https://github.com/npm/cli/issues/7814#issuecomment-2488626736
119-
# → https://github.com/amazonlinux/amazon-linux-2023/issues/840#issuecomment-2485782075
120-
# → https://lore.kernel.org/io-uring/[email protected]/T/#m57570b5f8f2fc00d5a17cfe18ffeeba9fc23a43d
121-
echo 'export UV_USE_IO_URING=${UV_USE_IO_URING:-0}' >> "$bp_dir/export"
122-
123111
# ensure corepack installed binaries are findable by downstream buildpacks
124112
echo "export COREPACK_HOME=\"$build_dir/.heroku/corepack\"" >> "$bp_dir/export"
125113
fi

test/fixtures/libuv_io_uring_fix/README.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/fixtures/libuv_io_uring_fix/package.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

test/run

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2057,21 +2057,6 @@ testConflictingPackageManagerMetadata() {
20572057
assertCapturedError
20582058
}
20592059

2060-
testDisableIoUringFix() {
2061-
compile "libuv_io_uring_fix"
2062-
assertCaptured "UV_USE_IO_URING is set to 0"
2063-
assertCapturedSuccess
2064-
}
2065-
2066-
testDisableIoUringFixUserOverride() {
2067-
cache_dir=$(mktmpdir)
2068-
env_dir=$(mktmpdir)
2069-
echo "1" > "$env_dir/UV_USE_IO_URING"
2070-
compile "libuv_io_uring_fix" "$cache_dir" "$env_dir"
2071-
assertCaptured "UV_USE_IO_URING is set to 1"
2072-
assertCapturedSuccess
2073-
}
2074-
20752060
# Utils
20762061

20772062
pushd "$(dirname 0)" >/dev/null

0 commit comments

Comments
 (0)