feat: add confirmation for DATs to be deleted with datacloud disconnect (#157)

* Add table for confirmation of DATs to be deleted

* CX feedback

Author: gsinghsfdc

src/commands/datacloud/disconnect.ts

@@ -26,15 +26,47 @@ export default class Disconnect extends Command {
     const {flags, args} = await this.parse(Disconnect)
     const {app, addon, confirm} = flags
     const {connection_name: connectionName} = args
+    let dataActionTargets: AppLink.DataActionTarget[] = []
+    let message: string | undefined
 
     await this.configureAppLinkClient(app, addon)
 
+    try {
+      const {body} = await this.applinkClient.get<AppLink.DataActionTarget[]>(
+        `/addons/${this.addonId}/connections/datacloud/${connectionName}/data_action_targets`,
+        {
+          headers: {authorization: `Bearer ${this._applinkToken}`},
+          retryAuth: false,
+        }
+      )
+      dataActionTargets = body || []
+    } catch {
+      ux.error('Failed to fetch data action targets for connection', {exit: 1})
+    }
+
+    if (dataActionTargets.length > 0) {
+      const lines: string[] = []
+      ux.table(dataActionTargets, {
+        label: {header: 'Data Action Target Name'},
+      }, {
+        printLine: (line: string) => lines.push(line),
+      })
+
+      const tableStr = lines.join('\n')
+      const intro = heredoc`
+          Destructive action
+          This command disconnects the org ${color.bold.red(connectionName)} from add-on ${color.addon(this._addonName)} on app ${color.app(app)} and deletes the following data action targets:`
+
+      message = `${intro}\n${tableStr}`
+    }
+
     await confirmCommand({
       connectionName,
       connectionType: 'org',
       addon: this._addonName,
       app,
       confirm,
+      message,
     })
 
     try {

src/lib/applink/types.ts

@@ -132,6 +132,20 @@ export type DataActionTargetCreate = {
   }
 }
 
+/**
+ * A Data Action Target.
+ */
+export type DataActionTarget = {
+  readonly id: string
+  readonly type: string
+  readonly label: string
+  readonly api_name: string
+  readonly status: string
+  readonly target_endpoint: string
+  readonly connection_id: string
+  readonly app_id: string
+}
+
 /**
  * Create Authorization process.
  */

test/commands/datacloud/disconnect.test.ts

@@ -15,6 +15,18 @@ import {
 import {CLIError} from '@oclif/core/lib/errors'
 import stripAnsi from '../../helpers/strip-ansi'
 import heredoc from 'tsheredoc'
+import {ux} from '@oclif/core'
+import * as sinon from 'sinon'
+
+const stdOutputMockStart = () => {
+  stderr.start()
+  stdout.start()
+}
+
+const stdOutputMockStop = () => {
+  stderr.stop()
+  stdout.stop()
+}
 
 describe('datacloud:disconnect', function () {
   let api: nock.Scope
@@ -46,10 +58,13 @@ describe('datacloud:disconnect', function () {
       api.done()
       applinkApi.done()
       nock.cleanAll()
+      sinon.restore()
     })
 
     it('shows the expected output after failing', async function () {
       applinkApi
+        .get('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/datacloud/myorg/data_action_targets')
+        .reply(200, [])
         .delete('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/myorg')
         .reply(202, connection5_disconnection_failed)
 
@@ -68,6 +83,8 @@ describe('datacloud:disconnect', function () {
 
     it('waits for DELETE /connections/orgName status to return "disconnecting" before ending the action successfully', async function () {
       applinkApi
+        .get('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/datacloud/myorg/data_action_targets')
+        .reply(200, [])
         .delete('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/myorg')
         .reply(202, connection5_disconnecting)
 
@@ -83,6 +100,8 @@ describe('datacloud:disconnect', function () {
 
     it('connection not found', async function () {
       applinkApi
+        .get('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/datacloud/myorg/data_action_targets')
+        .reply(200, [])
         .delete('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/myorg')
         .replyWithError(ConnectionError_record_not_found)
 
@@ -102,6 +121,9 @@ describe('datacloud:disconnect', function () {
     })
 
     it('errors when the wrong org name is passed to the confirm flag', async function () {
+      applinkApi
+        .get('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/datacloud/myorg/data_action_targets')
+        .reply(200, [])
       try {
         await runCommand(Cmd, [
           'myorg',
@@ -114,5 +136,58 @@ describe('datacloud:disconnect', function () {
         expect(oclif.exit).to.equal(1)
       }
     })
+
+    it('prompts with DAT table when data action targets exist (no indent)', async function () {
+      applinkApi
+        .get('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/datacloud/myorg/data_action_targets')
+        .reply(200, [
+          {
+            label: 'Target One',
+            api_name: 'TargetOne',
+          },
+          {
+            label: 'Target Two',
+            api_name: 'TargetTwo',
+          },
+        ])
+        .delete('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/myorg')
+        .reply(202, connection5_disconnecting)
+
+      sinon.stub(ux, 'prompt').resolves('myorg')
+      stdOutputMockStart()
+      await runCommand(Cmd, [
+        'myorg',
+        '--app=my-app',
+      ])
+      stdOutputMockStop()
+
+      expect(stderr.output).to.contain('Destructive action')
+      expect(stderr.output).to.contain('Data Action Target Name')
+      expect(stderr.output).to.contain('Target One')
+      expect(stderr.output).to.contain('Target Two')
+    })
+
+    it('prompts without DAT table when no data action targets exist', async function () {
+      applinkApi
+        .delete('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/myorg')
+        .reply(202, connection5_disconnecting)
+        .get('/addons/01234567-89ab-cdef-0123-456789abcdef/connections/datacloud/myorg/data_action_targets')
+        .reply(200, [])
+
+      sinon.stub(ux, 'prompt').resolves('myorg')
+      stdOutputMockStart()
+      await runCommand(Cmd, [
+        'myorg',
+        '--app=my-app',
+      ])
+      stdOutputMockStop()
+
+      console.log(stderr.output)
+
+      expect(stderr.output).to.contain('Destructive action')
+      expect(stderr.output).to.contain('This command disconnects the org myorg')
+      expect(stderr.output).to.not.contain('data action targets')
+      expect(stderr.output).to.not.contain('Data Action Target Name')
+    })
   })
 })