-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Select field label does not focus the component #4946
Comments
Could you record a video for me to have a look? I can't do it this way here. |
Ok actually I might have this slightly wrong, standard behavior isn't that the select menu opens when the label is clicked. But it does give focus to the control, and in HeroUI it does nothing. So this is behavior show via the HeroUI docs site (label click does nothing) vs this from say the react-aria-components docs (label click focuses the select) or this from MDN on a normal native select (label click focuses the select - though their CSS makes it look odd) |
I also noticed that clicking on the label does not open the associated select input. In many UI, clicking on the label is expected to focus or open the input for better usability and accessibility. Is this behavior intentional or not |
@wingkwong can I work on this issue? |
@wingkwong should we also trigger an hover on select when the label is hovered? |
@abhinav700 hovering shouldn't trigger it. The issue here is when clicking an label, the component should be focused. |
@wingkwong got it. |
@wingkwong I have become busy with some work and won't be able to work on this issue. |
HeroUI Version
2.7.2
Describe the bug
Clicking on the label for the Select component doesn't open the picker. This is visible when using the "outside" label placement variants.
Visible in the HeroUI docs site
Your Example Website or App
https://www.heroui.com/docs/components/select#label-placements
Steps to Reproduce the Bug or Issue
Expected behavior
I am expecting the select dropdown to open
Screenshots or Videos
No response
Operating System Version
MacOS
Browser
Chrome
The text was updated successfully, but these errors were encountered: