Missing mapping in oneOf with discriminator

[hnykda]

Description

Hi.

I have this:

    "/tasks/chat": {
      "post": {
        "summary": "Create Chat Task",
        "description": "Create a new chat task.",
        "operationId": "create_chat_task_tasks_chat_post",
        "requestBody": {
          "content": {
            "application/json": {
              "schema": {
                "oneOf": [
                  {
                    "$ref": "#/components/schemas/StandaloneChatRequestParams"
                  },
                  {
                    "$ref": "#/components/schemas/MapReduceChatRequestParams"
                  }
                ],
                "title": "Request",
                "discriminator": {
                  "propertyName": "processing_mode",
                  "mapping": {
                    "standalone": "#/components/schemas/StandaloneChatRequestParams",
                    "map": "#/components/schemas/MapReduceChatRequestParams",
                    "reduce": "#/components/schemas/MapReduceChatRequestParams"
                  }
                }
              }
            }
          },
          "required": true
        },

but with the following config:

import { defineConfig, defaultPlugins } from "@hey-api/openapi-ts";

export default defineConfig({
  input: "http://localhost:8000/openapi.json",
  output: "src/lib/engine_api/generated",
  plugins: [
    ...defaultPlugins,
    {
      name: "@hey-api/client-next",
      runtimeConfigPath: "./src/lib/engine_api/main.ts",
    },
    {
      enums: "javascript",
      name: "@hey-api/typescript",
    },
  ],
});

I get:

export type CreateChatTaskTasksChatPostData = {
  body:
    | ({
        processing_mode?: "standalone";
      } & StandaloneChatRequestParams)
    | ({
        processing_mode?: "map";
      } & MapReduceChatRequestParams);
  path?: never;
  query?: never;
  url: "/tasks/chat";
};

i.e. reduce mapping is missing. Seems that it's order dependent. When I switch the order of map with reduce in the original JSON, it gets generated with reduced instead (and map is missing).

Reproducible example or configuration

No response

OpenAPI specification (optional)

No response

System information (optional)

No response

[mrlubos]

Thanks @hnykda! Would you be interested in creating a pull request with the fix?

[hnykda]

Very unlikely, sorry!

[mrlubos]

All good! Worth checking 😀

[hnykda]

I agree!

And thank you for your work, very appreciated 👍