Client breaks Next 'revalidate'

[adamghowiba]

Description

When using @hey-api/client-fetch generated functions with Next.js, it seems to break the caching methods of Next.js.

Next.js wraps the default browser fetch and adds some addtional functionaility such as revalidate. Which allows requests to be cached, and revalidated.

For some reason when using standard fetch revalidate works, when using generated SDK functions they don't.

Reproducible example or configuration

page.tsx

import { listFilingTest } from '@ask-edgar/client/edgar-react-query';
import { API_BASE_URL } from '@ask-edgar/shared/constants';
import { TickerPage } from './TickerPage';

export default async function Ticker({
  params,
}: {
  params: Promise<{ ticker: string }>;
}) {
  const { ticker } = await params;

  // This call does respect the revalidate option despite everything being the same
  const response = await fetch(`${API_BASE_URL}/v1/sec/${ticker}/filing-test`, {
    next: {
      revalidate: 300,
    },
  });

  // This function doesn't seem to respect the `revalidate` option.
  const heyApiGeneratedSDK = await listFilingTest({
    path: {
      ticker: ticker,
    },
    next: {
      revalidate: 300,
    },
  });

  return <TickerPage ticker={ticker} />;
}

OpenAPI specification (optional)

No response

System information (optional)

No response

[adamghowiba]

After going through the @hey-api/client-fetch I realized that this isn't actually using native fetch but instead using new Request() to construct the request.

If possible, do you have any work-arounds to handling this?

Just want to say I love what you guys are doing, it's been a life saver. I'm a personal sponer of the project, and I'm trying to convince my company to sponer the porject but interoping with NextJS features is big for us so hoping there can be some middle-ground

[mrlubos]

@adamghowiba Thanks! How is this for the middle ground? https://heyapi.dev/openapi-ts/clients/next-js

[adamghowiba]

@adamghowiba Thanks! How is this for the middle ground? https://heyapi.dev/openapi-ts/clients/next-js

You're truly a diamond in the rough when it comes to open source. Thanks for all the great work.

I'll keep bugging my company to sponser, thanks!

[mrlubos]

No worries! Let me know if you run into any issues with the Next.js client!