Skip to content

Additional clarity to run integration tests #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimiHunjan opened this issue Apr 4, 2025 · 0 comments · Fixed by #3026
Closed

Additional clarity to run integration tests #3025

SimiHunjan opened this issue Apr 4, 2025 · 0 comments · Fixed by #3026
Labels
enhancement New feature or request

Comments

@SimiHunjan
Copy link
Contributor

SimiHunjan commented Apr 4, 2025

Problem

When learning how to run the integretion tests for local development, I referenced the instructions in the readme here: https://github.com/hiero-ledger/hiero-sdk-js?tab=readme-ov-file#start-tests.

The local node link in the SDK readme takes me to the local node repo readme which has a couple different ways to run the local node. I tried the docker compose way and it seems the recommended way to start the local node to run integration tests is npm run start. If there is a recommended approach from the team we should document that in the readme.

Once local node was up and running, the readme states a command to run the integration tests.

task test:integration:node

The following errors were observed:

Error: Failed to construct client for IntegrationTestDev

The problem was that the env.sample file in the root directory needed to be renamed to .env and populated with the correct information.

It required the operator account ID and private key from an account created with local node. It also needed the network to be changed.

Solution

We should include all instructions necessary to run the integration tests successfully in the readme.

Alternatives

No response

@SimiHunjan SimiHunjan added the enhancement New feature or request label Apr 4, 2025
@SimiHunjan SimiHunjan mentioned this issue Apr 4, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant