Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the terminology correct for what is beta and beta_prod_t? #26

Open
gauravjain14 opened this issue Mar 23, 2025 · 0 comments
Open

Is the terminology correct for what is beta and beta_prod_t? #26

gauravjain14 opened this issue Mar 23, 2025 · 0 comments

Comments

@gauravjain14
Copy link

https://github.com/hkproj/pytorch-stable-diffusion/blob/6e6900078372af15eb1b13e73068cd563784f377/sd/ddpm.py#L64C9-L64C39

The implementation makes sense from what the equations say but I was confused for a minute with using the term beta_prod_t.

What is beta?
beta = 1 - alpha

and

alpha_prod_t = prod(alpha_0, alpha_1, ...., alpha_t)

What will be the product of beta till timestep t?

(IIUC) beta_prod_t = prod(1-alpha_0, 1-alpha_1, ..., 1-alpha_t)

which is not equivalent to 1 - alpha_prod_t

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant