Path: channel/manage_booking_by_date.xhtml
Description
There is an issue in the Online Booking refund flow on the manage_booking_by_date page (Refund tab), where the refundable total is calculated incorrectly, causing the refund process to terminate.
Issue
For Online Bookings:
bookingControllerViewScope.refundableTotal is always calculated as 0
- This causes the refund process to terminate prematurely
Details
For Online Booking, in the Refund tab:
selectedBillSession.bill.referenceBill.billFeesWithoutZeroValue are loaded as BillFees for refund.
- The rendered
BillFee.tmpChangedValue values are should be used to determine the refund amount.
However,
bookingControllerViewScope.refundableTotal is calculated using
selectedBillSession.getBill().getBillFees().tmpChangedValue
This creates a mismatch because:
- The UI uses reference bill fees
- The backend calculation uses current bill fees
Related Methods: (BookingControllerViewScope)
calRefundTotal()
checkRefundTotal()
channelBookingRefund()
Path:
channel/manage_booking_by_date.xhtmlDescription
There is an issue in the Online Booking refund flow on the manage_booking_by_date page (Refund tab), where the refundable total is calculated incorrectly, causing the refund process to terminate.
Issue
For Online Bookings:
bookingControllerViewScope.refundableTotalis always calculated as 0Details
For Online Booking, in the Refund tab:
selectedBillSession.bill.referenceBill.billFeesWithoutZeroValueare loaded as BillFees for refund.BillFee.tmpChangedValuevalues are should be used to determine the refund amount.However,
bookingControllerViewScope.refundableTotalis calculated usingselectedBillSession.getBill().getBillFees().tmpChangedValueThis creates a mismatch because:
Related Methods: (BookingControllerViewScope)
calRefundTotal()checkRefundTotal()channelBookingRefund()