Skip to content

Commit 09eaba2

Browse files
authored
Merge pull request #1206 from zickgraf/master
Replace double quotes by single quotes in function names
2 parents c8130b4 + 33f75d6 commit 09eaba2

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

CAP/PackageInfo.g

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
1010

1111
PackageName := "CAP",
1212
Subtitle := "Categories, Algorithms, Programming",
13-
Version := "2022.12-10",
13+
Version := "2022.12-11",
1414
Date := Concatenation( "01/", ~.Version{[ 6, 7 ]}, "/", ~.Version{[ 1 .. 4 ]} ),
1515
License := "GPL-2.0-or-later",
1616

CAP/gap/InstallAdds.gi

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ InstallGlobalFunction( CapInternalInstallAdd,
203203
local install_func, replaced_filter_list, needs_wrapping, i, is_derivation, is_final_derivation, is_precompiled_derivation, without_given_name, with_given_name,
204204
without_given_weight, with_given_weight, number_of_proposed_arguments, current_function_number,
205205
current_function_argument_number, current_additional_filter_list_length, input_human_readable_identifier_getter, input_sanity_check_functions,
206-
output_human_readable_identifier_getter, output_sanity_check_function;
206+
output_human_readable_identifier_getter, output_sanity_check_function, name;
207207

208208
if IsFinalized( category ) then
209209
Error( "cannot add methods anymore, category is finalized" );
@@ -615,24 +615,27 @@ InstallGlobalFunction( CapInternalInstallAdd,
615615
Display( "WARNING: IsIdenticalObj is used for deciding the equality of objects but the caching is not set to crisp. Thus, probably the specification that equal input gives equal output is not fulfilled. You can suppress this warning by passing the option \"SuppressCacheWarning := true\" to AddIsEqualForObjects." );
616616
fi;
617617

618+
# work around https://github.com/gap-system/gap/issues/5259
619+
name := ReplacedString( Name( category ), "\"", "'" );
620+
618621
# set name for debugging purposes
619622
if NameFunction( i[ 1 ] ) in [ "unknown", "_EVALSTRINGTMP" ] then
620623

621624
if is_derivation then
622625

623-
SetNameFunction( i[ 1 ], Concatenation( "Derivation (first added to ", Name( category ), ") of ", function_name ) );
626+
SetNameFunction( i[ 1 ], Concatenation( "Derivation (first added to ", name, ") of ", function_name ) );
624627

625628
elif is_final_derivation then
626629

627-
SetNameFunction( i[ 1 ], Concatenation( "Final derivation (first added to ", Name( category ), ") of ", function_name ) );
630+
SetNameFunction( i[ 1 ], Concatenation( "Final derivation (first added to ", name, ") of ", function_name ) );
628631

629632
elif is_precompiled_derivation then
630633

631-
SetNameFunction( i[ 1 ], Concatenation( "Precompiled derivation added to ", Name( category ), " for ", function_name ) );
634+
SetNameFunction( i[ 1 ], Concatenation( "Precompiled derivation added to ", name, " for ", function_name ) );
632635

633636
else
634637

635-
SetNameFunction( i[ 1 ], Concatenation( "Function added to ", Name( category ), " for ", function_name ) );
638+
SetNameFunction( i[ 1 ], Concatenation( "Function added to ", name, " for ", function_name ) );
636639

637640
fi;
638641

0 commit comments

Comments
 (0)