-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert zeroconf integration to use python-zeroconf #24115
Comments
https://bugs.python.org/issue29883 issue holding implementation fix for this possibly for python 3.8, not that it helps us unless we can monkey patch it in. |
Before we revert anything... It looks to me like If we want to move towards native asyncio integrations as gold standard AND support Windows, is it more appropriate to reconsider uvloop on Windows? Is it better to build on an event loop that supports UDP or on one thats a bit faster but is incomplete? Would this probably go away if we used the stock event loop on Windows? |
Arrgh its super lame that the other event loop doesn't support subprocesses. |
My bad for not writing down why alternatives won't work, but it looks like you figured it out. Given the Python release schedule, we can expect Python 3.9 in either 2020 or 2021. When that happens, we will adopt Python 3.8 as our minimum version and can migrate back… |
Just for other readers:
|
We need Proactor event loop on windows because we have more as 512 current coroutines because we have a lot of async functions they are awaited. That was the reason why we move over to this on windows initial. |
Python 3.8 contains a new event loop https://twitter.com/VictorStinner/status/1133323227298697216 |
We migrated the zeroconf integration to use aiozeroconf. However, @amelchio notified us that
asyncio.create_datagram_endpoint
is not supported on Windows. So we need to migrate back to using python-zeroconf, which does work.CC @Kane610
The text was updated successfully, but these errors were encountered: