Allow some install failures (#66)

Author: sixlive

src/CommandTasks.php

@@ -48,9 +48,12 @@ public function setOutput(OutputStyle $output): self
      * @param  callable  $task
      * @return self
      */
-    public function addTask(string $name, callable $task): self
+    public function addTask(string $name, callable $task, bool $throwOnFail = false): self
     {
-        $this->tasks[$name] = $task;
+        $this->tasks[$name] = [
+            'task' => $task,
+            'throw_on_fail' => $throwOnFail,
+        ];
 
         return $this;
     }
@@ -65,7 +68,7 @@ public function addTask(string $name, callable $task): self
     public function runTasks(): void
     {
         Collection::make($this->tasks)->each(function ($task, $description) {
-            $result = $task();
+            $result = $task['task']();
 
             if ($this->output) {
                 $this->output->writeLn(vsprintf('%s: %s', [
@@ -76,7 +79,7 @@ public function runTasks(): void
 
             $this->results[$description] = $result;
 
-            if (! $result && $this->throwOnError) {
+            if (! $result && $task['throw_on_fail'] && $this->throwOnError) {
                 throw new TaskFailed(sprintf('%s failed, please review output and try again.', $description));
             }
         });

src/Commands/HoneybadgerInstallCommand.php

@@ -123,7 +123,8 @@ private function sendTest(): array
             'Send test exception to Honeybadger',
             function () use ($result) {
                 return ! empty($result);
-            }
+            },
+            true
         );
 
         return $result;

tests/CommandTasksTest.php

@@ -44,7 +44,7 @@ public function outputs_unsuccessful_tasks()
         $commandTasks->setOutput($output);
         $commandTasks->addTask('Example Task', function () {
             return false;
-        });
+        }, true);
 
         $commandTasks->runTasks();
 
@@ -73,7 +73,7 @@ public function outputs_multiple_tasks()
         });
         $commandTasks->addTask('Example failed task', function () {
             return false;
-        });
+        }, true);
 
         $commandTasks->runTasks();
 
@@ -94,7 +94,7 @@ public function whether_any_tasks_have_failed()
         });
         $commandTasks->addTask('Example failed task', function () {
             return false;
-        });
+        }, true);
 
         $commandTasks->runTasks();
 

tests/Commands/HoneybadgerInstallCommandTest.php

@@ -256,7 +256,7 @@ public function outputs_retry_text_if_any_tasks_fail()
 
         $command->expects($this->once())
             ->method('error')
-            ->with('Write HONEYBADGER_API_KEY to .env failed, please review output and try again.');
+            ->with('Send test exception to Honeybadger failed, please review output and try again.');
 
         $this->app[Kernel::class]->registerCommand($command);