Merge pull request #106 from honeybadger-io/logger-fixes

Logger fixes

Author: shalvah

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+- Fix LogHandler creation by passing constructor arguments
 
 ## [3.15.0] - 2023-02-16
 ### Added

src/HoneybadgerLaravel.php

@@ -43,7 +43,9 @@ public static function make(array $config): Reporter
                 'version' => self::VERSION.'/'.Honeybadger::VERSION,
             ],
             'service_exception_handler' => function (ServiceException $e) {
-                Log::error($e);
+                // Note: If you are using Honeybadger as a Logger, this exception
+                // can end up being reported to Honeybadger depending on your log level configuration.
+                Log::warning($e);
             },
         ], $config));
     }

src/HoneybadgerLogDriver.php

@@ -2,6 +2,7 @@
 
 namespace Honeybadger\HoneybadgerLaravel;
 
+use Honeybadger\Contracts\Reporter;
 use Honeybadger\LogHandler;
 use Illuminate\Support\Facades\App;
 use Monolog\Logger;
@@ -11,7 +12,11 @@ class HoneybadgerLogDriver
     public function __invoke(array $config): Logger
     {
         return tap(new Logger($config['name'] ?? 'honeybadger'), function ($logger) {
-            $logger->pushHandler(App::make(LogHandler::class));
+            $logHandler = App::makeWith(LogHandler::class, [
+                App::make(Reporter::class),
+                $config['level'] ?? 'error'
+            ]);
+            $logger->pushHandler($logHandler);
         });
     }
 }

tests/Commands/HoneybadgerCheckinCommandTest.php

@@ -8,9 +8,16 @@
 use Honeybadger\HoneybadgerLaravel\Commands\HoneybadgerCheckinCommand;
 use Honeybadger\Tests\TestCase;
 use Illuminate\Contracts\Console\Kernel;
+use Illuminate\Support\Facades\Config;
 
 class HoneybadgerCheckinCommandTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        Config::set('honeybadger.report_data', true);
+    }
+
     /** @test */
     public function it_sends_a_test_exception_to_honeybadger()
     {

tests/Commands/HoneybadgerInstallCommandTest.php

@@ -12,6 +12,12 @@
 
 class HoneybadgerInstallCommandTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        Config::set('honeybadger.report_data', true);
+    }
+
     /** @test */
     public function prompts_for_options_and_outputs_all_successful_operations()
     {

tests/Commands/HoneybadgerTestCommandTest.php

@@ -8,9 +8,16 @@
 use Honeybadger\HoneybadgerLaravel\Exceptions\TestException;
 use Honeybadger\Tests\TestCase;
 use Illuminate\Contracts\Console\Kernel;
+use Illuminate\Support\Facades\Config;
 
 class HoneybadgerTestCommandTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        Config::set('honeybadger.report_data', true);
+    }
+
     /** @test */
     public function it_sends_a_test_exception_to_honeybadger()
     {