Merge pull request #75 from janlam7/phpcs-tool-9

Update phpcs-tool to 9.1.0 with Hostnet-Level-1

Author: janlam7

.github/workflows/main.yaml

@@ -27,4 +27,5 @@ jobs:
                 run: composer install --no-progress --prefer-dist --optimize-autoloader
             -   name: phpunit
                 run: php vendor/bin/phpunit
-
+            -   name: phpcs
+                run: php vendor/bin/phpcs

composer.json

@@ -12,7 +12,7 @@
     },
     "require-dev": {
         "doctrine/annotations":          "^1.0",
-        "hostnet/phpcs-tool":            "^8.3",
+        "hostnet/phpcs-tool":            "^9.1.0",
         "phpunit/phpunit":               "^9.5.5",
         "sensio/framework-extra-bundle": "3.*|^5.0",
         "symfony/browser-kit":           "^4.0|^5.0",
@@ -41,6 +41,12 @@
             "test/Functional/Fixtures/TestKernel.php"
         ]
     },
+    "config": {
+        "allow-plugins": {
+            "hostnet/*":                                      true,
+            "dealerdirect/phpcodesniffer-composer-installer": false
+        }
+    },
     "archive": {
         "exclude": [
             "/test"

phpcs.xml.dist

@@ -4,5 +4,5 @@
     <exclude-pattern>test/Functional/Fixtures/TestKernel.php</exclude-pattern>
 
     <!-- Use the Hostnet code conventions -->
-    <rule ref="Hostnet" />
+    <rule ref="Hostnet-Level-1" />
 </ruleset>

phpunit.xml.dist

@@ -5,9 +5,6 @@
       <directory>src</directory>
     </include>
   </coverage>
-  <listeners>
-    <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/>
-  </listeners>
   <testsuites>
     <testsuite name="hostnet/form-handler-bundle test suite">
       <directory>./test</directory>

test/Functional/Fixtures/HandlerType/FullFormHandler.php

@@ -18,7 +18,7 @@
 
 class FullFormHandler implements HandlerTypeInterface, ActionSubscriberInterface
 {
-    public function configure(HandlerConfigInterface $config)
+    public function configure(HandlerConfigInterface $config): void
     {
         $config->setType(TestType::class);
         $config->registerActionSubscriber($this);

test/Functional/Fixtures/HandlerType/FullFormHandler27.php

@@ -17,7 +17,7 @@
 
 class FullFormHandler27 implements HandlerTypeInterface, ActionSubscriberInterface
 {
-    public function configure(HandlerConfigInterface $config)
+    public function configure(HandlerConfigInterface $config): void
     {
         $config->setType('test');
         $config->registerActionSubscriber($this);

test/Functional/Fixtures/HandlerType/SimpleFormHandler.php

@@ -12,7 +12,7 @@
 
 class SimpleFormHandler implements HandlerTypeInterface
 {
-    public function configure(HandlerConfigInterface $config)
+    public function configure(HandlerConfigInterface $config): void
     {
         $config->setType(TestType::class);
     }

test/Functional/Fixtures/HandlerType/SimpleNotTaggedFormHandler.php

@@ -12,7 +12,7 @@
 
 class SimpleNotTaggedFormHandler implements HandlerTypeInterface
 {
-    public function configure(HandlerConfigInterface $config)
+    public function configure(HandlerConfigInterface $config): void
     {
         $config->setType(TestType::class);
     }

test/Functional/Fixtures/TestKernel.php

@@ -40,15 +40,15 @@ public static function getLegacyConfigFilename()
         return 'config_27.yml';
     }
 
-    public function getProjectDir()
+    public function getProjectDir(): string
     {
         return __DIR__;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return array(
             new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
@@ -75,15 +75,15 @@ protected function prepareContainer(ContainerBuilder $container)
     /**
      * {@inheritdoc}
      */
-    public function getCacheDir()
+    public function getCacheDir(): string
     {
         return __DIR__.'/../../../var/cache/'.md5($this->getEnvironment().$this->config_file);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getLogDir()
+    public function getLogDir(): string
     {
         return __DIR__.'/../../../var/logs';
     }

test/Functional/Fixtures/TestType.php

@@ -13,12 +13,12 @@
 
 class TestType extends AbstractType
 {
-    public function buildForm(FormBuilderInterface $builder, array $options)
+    public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         $builder->add('test', TextType::class);
     }
 
-    public function configureOptions(OptionsResolver $resolver)
+    public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
             'data_class' => TestData::class,