Skip to content

Commit 46f6e1f

Browse files
Optimize error paths in qvi_hwloc_bitmap_s. (#253)
Signed-off-by: Samuel K. Gutierrez <[email protected]>
1 parent 6146b9f commit 46f6e1f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/qvi-hwloc.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -428,23 +428,23 @@ struct qvi_hwloc_bitmap_s {
428428
qvi_hwloc_bitmap_s(void)
429429
{
430430
const int rc = qvi_hwloc_bitmap_calloc(&m_data);
431-
if (rc != QV_SUCCESS) throw qvi_runtime_error();
431+
if (qvi_unlikely(rc != QV_SUCCESS)) throw qvi_runtime_error();
432432
}
433433
/** Construct via hwloc_const_bitmap_t. */
434434
explicit qvi_hwloc_bitmap_s(hwloc_const_bitmap_t bitmap)
435435
{
436436
int rc = qvi_hwloc_bitmap_calloc(&m_data);
437-
if (rc != QV_SUCCESS) throw qvi_runtime_error();
437+
if (qvi_unlikely(rc != QV_SUCCESS)) throw qvi_runtime_error();
438438
rc = set(bitmap);
439-
if (rc != QV_SUCCESS) throw qvi_runtime_error();
439+
if (qvi_unlikely(rc != QV_SUCCESS)) throw qvi_runtime_error();
440440
}
441441
/** Copy constructor. */
442442
qvi_hwloc_bitmap_s(const qvi_hwloc_bitmap_s &src)
443443
{
444444
int rc = qvi_hwloc_bitmap_calloc(&m_data);
445-
if (rc != QV_SUCCESS) throw qvi_runtime_error();
445+
if (qvi_unlikely(rc != QV_SUCCESS)) throw qvi_runtime_error();
446446
rc = set(src.m_data);
447-
if (rc != QV_SUCCESS) throw qvi_runtime_error();
447+
if (qvi_unlikely(rc != QV_SUCCESS)) throw qvi_runtime_error();
448448
}
449449
/** Destructor. */
450450
~qvi_hwloc_bitmap_s(void)
@@ -463,7 +463,7 @@ struct qvi_hwloc_bitmap_s {
463463
operator=(const qvi_hwloc_bitmap_s &src)
464464
{
465465
const int rc = qvi_hwloc_bitmap_copy(src.m_data, m_data);
466-
if (rc != QV_SUCCESS) throw qvi_runtime_error();
466+
if (qvi_unlikely(rc != QV_SUCCESS)) throw qvi_runtime_error();
467467
}
468468
/** Sets the object's internal bitmap to match src's. */
469469
int

0 commit comments

Comments
 (0)