Skip to content

Ensure exceptions raised in ParameterValue subclass constructors are raised to the user #811

Open
@aplowman

Description

@aplowman

We are using a ValueError at the moment in:

def get_relative_path(path1: Sequence[T], path2: Sequence[T]) -> Sequence[T]:

The problem is we then have to catch a ValueError in

def _get_relevant_paths(

...which is masking any ValueError raised by ParameterValue sub-class constructors. For example, in MatFlow: Orientations.from_file.

EDIT: maybe that's not the right place actually, but I think the issue still stands.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    Projects

    Status

    🔲 Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions