Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Height overwrites width on images with both dimensions #498

Closed
towerofnix opened this issue May 25, 2024 · 0 comments · Fixed by #502
Closed

Height overwrites width on images with both dimensions #498

towerofnix opened this issue May 25, 2024 · 0 comments · Fixed by #502
Labels
scope: page generation - content type: bug (user-facing)

Comments

@towerofnix
Copy link
Member

In the definition for imgAttributes, under image:

slots.dimensions?.[0] &&
  {width: slots.dimensions[0]},

slots.dimensions?.[1] &&
  {width: slots.dimensions[1]},

The latter line should be height!

This may be tangentially related to #478.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: page generation - content type: bug (user-facing)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix content images overwriting width with height hsmusic/hsmusic-wiki
1 participant
@towerofnix