-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chronology tooltip #523
Merged
Merged
Chronology tooltip #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It lives!
Sorry, this is just maintaining the test paths that exist and dropping the ones which don't apply anymore.
This is unfortunately necessary to avoid the meaningless 'text-with-tooltip-interaction-cue' class (if there's no tooltip).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves chronology links from the nav bar, to contribution tooltips.
Resolves #520.
Design notes and motivating factors, in no particular order:
Implementation notes:
nextBySameArtist
andpreviousBySameArtist
properties on individual contributions, and supporting infrastructure—similar tothingProperty
, contributions get a newartistProperty
, and this identifies the reverse contribution list to read off the contribution's (singular) artist. It's very similar behavior as oldgetChronologyRelations
, but is more focused (it only treats a single list as chronology), is isolated to the appropriate area (part of data code, not content), and intrinsically true (the previous/next relations can be understood in a vacuum, by any part of code).composite/data/index.js
, instead of being manually duplicated in related files).linkExternalAsIcon
is removed and replaced with more compositional helper utilities,generateExternal{Handle,Icon,Platform}
.linkContribution
intogenerateContributionTooltip
, and broken into per-section components,generateContributionTooltip{ExternalLink,Chronology}Section
.linkContribution
as a slot, which controls which string is used for chronology info (e.g. "previous track art by this artist"). This is controlled by a component on the level of the particular page, generally slotted intogenerateReleaseInfoContributionsLine
orgenerateContributionList
.