Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort reverse reference lists by date, in data #536

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

towerofnix
Copy link
Member

Sorts reverse reference and contribution lists by date, notably using the intrinsically provided dates provided through withResolvedContribs (etc).

Lists are only sorted by the literal property date on the referencing things; additionally disambiguating sorting should be performed before or after. (Although for "before" - the sorting should be done to the array shared by all things, or else the caching is defeated. We declare sorting through YAML loading specs' sort step. Detailed discussion: #code-quarantine)

Re: #383, sorting occurs for every reverse reference list (of the respective input('data') and input('list') all at once, at the same time as the reverse lists / cache records are basically prepared (i.e. on the first call with those inputs). Although we haven't 100% confirmed this is never significantly consequential, some initial measures suggest we'd have to be dealing with pretty big data to run into trouble. (Intro: #code-quarantine, summary: #code-quarantine)

Resolves #529, fixing cover artwork chronology links (whose dates can vary from the respective track). We haven't integrated a predictable sort order into general content yet, and there probably needs to be a broader look at how sorted lists are represented to enable that (e.g. we should only sort according to language rules within ranges that are otherwise ambiguous).

@towerofnix towerofnix added type: bug (user-facing) scope: data processing type: groundworks Changes are foundational to further issues & code work labels Jun 26, 2024
@towerofnix towerofnix merged commit c28cfca into preview Jun 26, 2024
@towerofnix towerofnix deleted the sort-rev-refs branch June 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: data processing type: bug (user-facing) type: groundworks Changes are foundational to further issues & code work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artist reverse contribution lists must be sorted chronologically
1 participant