-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search result focus improvements #556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks basically great now!! Just a couple code-nitpicky comments and it should be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested locally and this works! We'll merge this ourselves when we can LOL - thanks!
1669684
to
0ef441d
Compare
...rather than tracking value changes, which is finnicky and broke how we detected pressing enter/return to acivate search (on 'change' event)
HTMLInputElement: selectionchange still not available, boo hoo although this is probably appropriate wrt selection moving literally anywhere else - should also cancel focus-first-result
b137a0d
to
085ab0e
Compare
Closes #535
Uses hover styling for focused results, and allows using the up/down arrow keys to control focus.