Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result focus improvements #556

Merged
merged 13 commits into from
Jan 10, 2025

Conversation

leo60228
Copy link
Member

Closes #535

Uses hover styling for focused results, and allows using the up/down arrow keys to control focus.

Copy link
Member

@towerofnix towerofnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks basically great now!! Just a couple code-nitpicky comments and it should be good to go!

@leo60228 leo60228 requested a review from towerofnix September 14, 2024 22:04
Copy link
Member

@towerofnix towerofnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

Copy link
Member

@towerofnix towerofnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested locally and this works! We'll merge this ourselves when we can LOL - thanks!

@towerofnix towerofnix merged commit 085ab0e into hsmusic:preview Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search box keyboard navigability
2 participants