Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Album social embeds fail when only a date is present #555

Closed
towerofnix opened this issue Sep 11, 2024 · 0 comments · Fixed by #557
Closed

Album social embeds fail when only a date is present #555

towerofnix opened this issue Sep 11, 2024 · 0 comments · Fixed by #557
Labels
scope: page generation - content type: bug

Comments

@towerofnix
Copy link
Member

This is because hasAny is accidentally not based on hasDate, leading to partial data: hasDate: true but date: undefined. Oops!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: page generation - content type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various social embed fixes hsmusic/hsmusic-wiki
1 participant
@towerofnix