Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various social embed fixes #557

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Various social embed fixes #557

merged 7 commits into from
Sep 12, 2024

Conversation

towerofnix
Copy link
Member

Fixes stuff to do with social embeds! This does not change the intended contents of social embeds, but it does restore that intention, which was never ported to content functions correctly (dear god).

  • Resolves Album social embeds fail when only a date is present #555 by reworking that whole content function.
  • Fixes social embeds not having the "author" line (not reflecting the headingContent slot), by fixing the link to the separate oembed.json file not actually being generated.
    • For albums this is "(First group name) | HSMusic Wiki"
    • For tracks this is "(Album name) | HSMusic Wiki"
  • Fixes track social embeds not having descriptions - this was just never ported(!?)
    • This includes artist and cover artist names.
  • Fixes album "author" lines (headings) showing the group directory instead of name
    • This was never apparent because that heading line wasn't displayed at all

There are some supporting internal changes, too.

  • WikiInfo.canonicalBase now always ends with a slash
  • pagePathStringFromRoot is a new extra dependency and is literally the path to the page you are visiting, as a string, e.g. "track/sburban-jungle/".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Album social embeds fail when only a date is present
1 participant