Fix up artist nav links + add "imaginary-sibling" metatag #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options were already [html.onlyIfContent], so this seems like a bit of an oversight (it's possible for *none* of the options to have content).
Missed this one before, whoops.
So not really factored out much at all, but eh.
That means it's a throw, instead of silently dropping the content,
when you pass it through html.metatag('imaginary-sibling').
towerofnix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoopsey, when we were doin' dot links (which has no pull request 👍) we didn't end up getting artist nav links updated like (hopefully) the rest of 'em. This PR fixes that!
It also adds
html.metatag('imaginary-sibling'), which is a blank tag that is completely ignored when you're doing serialization (toString). Instead of doing anything with its own content (which it can't have at all), it just marks that sibling tags with the[html.onlyIfSiblings]attribute (#510) should in fact show themselves up.This basically means we can steal the
onlyIfSiblingsattribute out from a slotted-in child, use that for ourselves, and neutralize the effect of the tag on the child, which itself isn't going to have any siblings - not within the tag we're wrapping it under.This PR also fixes #576 along the way, why not.