Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up artist nav links + add "imaginary-sibling" metatag #577

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

towerofnix
Copy link
Member

Whoopsey, when we were doin' dot links (which has no pull request 👍) we didn't end up getting artist nav links updated like (hopefully) the rest of 'em. This PR fixes that!

It also adds html.metatag('imaginary-sibling'), which is a blank tag that is completely ignored when you're doing serialization (toString). Instead of doing anything with its own content (which it can't have at all), it just marks that sibling tags with the [html.onlyIfSiblings] attribute (#510) should in fact show themselves up.

This basically means we can steal the onlyIfSiblings attribute out from a slotted-in child, use that for ourselves, and neutralize the effect of the tag on the child, which itself isn't going to have any siblings - not within the tag we're wrapping it under.

This PR also fixes #576 along the way, why not.

Options were already [html.onlyIfContent], so this seems like
a bit of an oversight (it's possible for *none* of the options
to have content).
Missed this one before, whoops.
So not really factored out much at all, but eh.
That means it's a throw, instead of silently dropping the content,
when you pass it through html.metatag('imaginary-sibling').
@towerofnix towerofnix changed the title Fix up artist nav links + "imaginary-sibling" metatag Fix up artist nav links + add "imaginary-sibling" metatag Nov 15, 2024
@towerofnix towerofnix merged commit 0bf5694 into preview Nov 15, 2024
@towerofnix towerofnix deleted the artist-nav-fix branch November 15, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content check in chunkwrap setter dun't work
1 participant