Error while parsing an empty response

[TheBlackArroVV]

If I have an API, which returns an empty response, for example, with 204 if I try to parse it, it will fail with Unknown MIME type. Is it expected?

I believe Net::HTTP gonna process it to empty hash.

Code to reproduce:

require "http"
response = HTTP.get("https://httpbin.org/status/204")
response.parse

[ixti]

Response#parse (without mime type specification) relies on response's MIME type. In the given example it's text/html, thus if you don't register HTML mime-type parser, it will fail with the above message. You can explicitly call #parse(:json), but in this case you will get:

/home/ixti/.gem/ruby/3.2.3/gems/json-2.12.2/lib/json/common.rb:338:in `parse': unexpected end of input at line 1 column 1 (JSON::ParserError)

All of the above are expected behaviours. Empty response is not a valid JSON, and I don't know if empty hash is really expected in this case, I would expect nil. Thus, I highly suggest to be more specific on what you want in your code:

begin
  payload = HTTP.get(url).parse(:json)
rescue JSON::ParserError
  warn "oops"
  payload = {}
end

Also, there's a proposal to have .acceptable API that will raise error on unexpected MIME-type.

PS: We need to change error type to be HTTP::ResponseParseError I think in case of failed parsing.

[TheBlackArroVV]

@ixti, got it, thanks for answer!

[ixti]

Closing in favor of #804